summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-09gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-09atobm: close memory leaksAlan Coopersmith
Fix leaks reported by Oracle Parfait (though they don't last long, since the program exits immediately after leaking): Error: Memory leak Memory leak [memory-leak] (CWE 401): Memory leak of pointer pointer allocated with _new_scan_list(bytes_per_scanline) at line 260 of atobm.c in function 'doit'. calloc called at line 180 in function '_new_scan_list' Allocated value returned to caller at line 193 pointer allocated at line 250 in function 'doit' with _new_scan_list(bytes_per_scanline) pointer leaks when (i + 1) >= <unknown> at line 275 and buf[0] != 0 at line 225. Error: Memory leak Memory leak [memory-leak] (CWE 401): Memory leak of pointer pointer allocated with _new_scan_list(bytes_per_scanline) at line 316 of atobm.c in function 'doit'. calloc called at line 180 in function '_new_scan_list' Allocated value returned to caller at line 193 pointer allocated at line 250 in function 'doit' with _new_scan_list(bytes_per_scanline) pointer leaks when slist != NULL at line 252 and (i + 1) >= <unknown> at line 275 and (i + 1) >= <unknown> at line 303. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-09atobm: accept single character linesAlan Coopersmith
Fixes round-trip-test failure on hlines2 The previous behavior has been present since the initial checkin of the code to the X Consortium monolith, but no explanation was given for why a single-character line should be skipped. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-09test: add round-trip-test for atobm & bmtoaAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-09Move bitmaps into a new bitmaps directoryAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-03Build xz tarballs instead of bzip2Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-03gitlab CI: add a basic build testAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-05-14bitmap: Fix a crash with underspecified dimensionsJeremy Mates
From the reporter on #xorg-devel: -!- thrig [thrig@unaffilaited/thrig] has joined #xorg-devel <thrig> where does the code for bitmap live? there's a crash (or who knows on some platforms) if you `bitmap -size 42`
2020-07-23Fix spelling/wording issuesAlan Coopersmith
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-06-01Use _CONST_X_STRING to make libXt declare String as const char *Alan Coopersmith
Clears 169 out of 240 -Wdiscarded-qualifiers warnings from gcc 7.3 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-02-10bitmap 1.0.9bitmap-1.0.9Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-21Update configure.ac bug URL for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-16Update README for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2017-09-24same time ago the user Frederic Baldit complained (on xorg) thatWalter Harms
the ability to set single dots in the programm Bitmap depend on the state of num_lock. This is a long standing bug that affect all versions of bitmap. the problem was that the corresponding function was erroneously checking event->xbutton.state. Removing that check solved the problem for the user. Signed-off-by: wharms <wharms@bfs.de>
2017-01-26autogen: add default patch prefixMihail Konev
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2015-01-16bitmap 1.0.8bitmap-1.0.8Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-12-29Stop memory leak in XmuWriteBitmapDataToFile()Alan Coopersmith
StripFilename() allocates a new string for its result, so after we're done with it, free it instead of just losing the pointer to it. Fixes errors found by Oracle Parfait 1.5.1 bug checking tool: Error: Memory leak (CWE 401) Memory leak of pointer basename allocated with StripFilename(filename) at line 712 of Bitmap.c in function 'XmuWriteBitmapDataToFile'. basename allocated at line 691 with StripFilename(filename). basename leaks when i >= data_length at line 702. Error: Memory leak (CWE 401) Memory leak of pointer basename allocated with StripFilename(filename) at line 715 of Bitmap.c in function 'XmuWriteBitmapDataToFile'. basename allocated at line 691 with StripFilename(filename). Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-12-29Stop memory leaks from XtNewString(StripFilename(filename))Alan Coopersmith
StripFilename() already allocates a new string for its result, we don't need to duplicate it and then lose the pointer to the first one. Fixes errors found by Oracle Parfait 1.5.1 bug checking tool: Error: Memory leak (CWE 401) Memory leak of pointer pointer allocated with StripFilename(filename) at line 1119 of Bitmap.c in function 'BWReadFile'. pointer allocated at line 1106 with StripFilename(filename). pointer leaks when StripFilename(filename) != NULL at line 1106. Error: Memory leak (CWE 401) Memory leak of pointer pointer allocated with StripFilename(filename) at line 1119 of Bitmap.c in function 'BWReadFile'. pointer allocated at line 1106 with StripFilename(filename). Error: Memory leak (CWE 401) Memory leak of pointer pointer allocated with StripFilename(filename) at line 1222 of Bitmap.c in function 'BWWriteFile'. pointer allocated at line 1202 with StripFilename(filename). pointer leaks when StripFilename(filename) != NULL at line 1202. Error: Memory leak (CWE 401) Memory leak of pointer pointer allocated with StripFilename(filename) at line 1222 of Bitmap.c in function 'BWWriteFile'. pointer allocated at line 1202 with StripFilename(filename). Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-01autogen.sh: Honor NOCONFIGURE=1Alan Coopersmith
See http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-01configure: Drop AM_MAINTAINER_MODEAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-01-01Use '& 7' instead '% 8' to silence clang analyzer warningJeremy Huddleston Sequoia
Graphics.c:569:10: warning: The result of the '<<' expression is undefined while (!QueryFlood(BW, x, y, value) && (x < x_right)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Graphics.c:470:7: note: expanded from macro 'QueryFlood' ((GetBit(BW->bitmap.image, x, y) !=\ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Graphics.c:66:9: note: expanded from macro 'GetBit' (1 << ((x) % 8))) ? 1 : 0)) ~~^~~~~~~~~~~~ Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2014-01-01Demacro modernization of NewSList to plug a memory leak during error handlingJeremy Huddleston Sequoia
atobm.c:248:6: warning: Potential leak of memory pointed to by 'slist' NewSList (); ^~~~~~~~~~~ atobm.c:209:3: note: expanded from macro 'NewSList' fprintf (stderr, "%s: unable to allocate char array\n", \ ^~~~~~~ atobm.c:259:6: warning: Potential leak of memory pointed to by 'old' NewSList (); ^~~~~~~~~~~ atobm.c:209:3: note: expanded from macro 'NewSList' fprintf (stderr, "%s: unable to allocate char array\n", \ ^~~~~~~ atobm.c:259:6: warning: Potential leak of memory pointed to by 'slist' NewSList (); ^~~~~~~~~~~ atobm.c:209:3: note: expanded from macro 'NewSList' fprintf (stderr, "%s: unable to allocate char array\n", \ ^~~~~~~ 3 warnings generated. Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2014-01-01Silence -Wbad-function-castJeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2014-01-01Avoid shadow declarationsJeremy Huddleston Sequoia
Bitmap.c:906:17: warning: declaration shadows a local variable [-Wshadow] unsigned char *image_data; ^ Bitmap.c:799:11: note: previous declaration is here char *image_data, *buffer_data; ^ Bitmap.c:907:8: warning: declaration shadows a local variable [-Wshadow] char *buffer_data; ^ Bitmap.c:799:24: note: previous declaration is here char *image_data, *buffer_data; ^ Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2014-01-01assert to avoid a NULL dereferenceJeremy Huddleston Sequoia
Bitmap.c:1246:8: warning: Dereference of null pointer **str = '\0'; ~~~~~~^~~~~~ 1 warning generated. Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2013-11-22Print which option was in error along with usage messageAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
2013-10-25config: replace deprecated use of AC_OUTPUT with AC_CONFIG_FILESGaetan Nadon
Fix Automake warning: AC_OUTPUT should be used without arguments. www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Files Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2013-06-06Use table markup in preference to various low-level constructions.Eric S. Raymond
2013-05-17bitmap 1.0.7bitmap-1.0.7Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-21Mark usage() functions as noreturn, as suggested by gccAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-21Simplify & unify error path between mktemp & mkstemp versionsAlan Coopersmith
This also now catches errors when fopen() or fdopen() fail, before we try to fwrite() to a null FILE pointer. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-21Fix genererate typo in bmtoa error messagesAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-20Combine usage messages into a single stringAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-09-22bitmap.man: Fix some typos.Bjarni Ingi Gislason
Remove stray backslash. (Added sometime between X11R4 and X11R5; 21+ years old.) Use two spaces between sentences, not one or two or three. Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is> Signed-off-by: James Cloos <cloos@jhcloos.com>
2012-05-29Fix pixmap leak in error paths of BWGetUnzoomedPixmapAlan Coopersmith
Found by Parfait 0.5.0.1 bug checking tool: Leaked X Resource pix at line 393 of Bitmap.c in function 'BWGetUnzoomedPixmap'. pix initialized at line 388 with XCreatePixmap(...). at line 414 of Bitmap.c in function 'BWGetUnzoomedPixmap'. pix initialized at line 409 with XCreatePixmap(...). Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-03-08bitmap 1.0.6bitmap-1.0.6Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-12-20Use lrint() from math library if availableAlan Coopersmith
Moves -lm from being hardcoded in Makefile.am to being added via AC_SEARCH_LIBS in configure.ac setting it in $(MATH_LIBS) Using lrint() [returns long int] instead of rint() [returns double] clears a bunch of gcc warnings of the form: "cast from function call of type ‘double’ to non-matching type ‘short int’" Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-14Constify strings in atobmAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-14Constify strings in bmtoaAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-14Strip trailing whitespaceAlan Coopersmith
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-14Constify filename string handlingAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-14Add const to char * in BWRequest typedefAlan Coopersmith
Fixes many gcc --Wwrite-string warnings of the form: Bitmap.c: In function ‘BWTPaste’: Bitmap.c:1913:7: warning: passing argument 2 of ‘BWEngageRequest’ discards qualifiers from pointer target type Bitmap.h:190:16: note: expected ‘BWRequest’ but argument is of type ‘const char *’ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-03-04man: use correct section number when referring to XGaetan Nadon
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-02-17atobm only depends on xproto, not x11Alan Coopersmith
It only includes <X11/Xos.h>, no headers or functions from libX11. Due to a typo in Makefile.am (also fixed) it wasn't actually linking with libX11 even though it had x11 in its PKG_CHECK_MODULES list. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-15Use autoconf standard HAVE_MKSTEMP define instead of old imake HAS_MKSTEMPAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-15config: Add missing AC_CONFIG_SRCDIRAlan Coopersmith
Regroup AC statements under the Autoconf initialization section. Regroup AM statements under the Automake initialization section. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-15Use fputs instead of fprintf with no format arg to print usage message.Alan Coopersmith
Clear gcc warning of: BitEdit.c:986: warning: format not a string literal and no format arguments Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Dirk Wallenstein <halsmit@t-online.de>
2011-01-15Call snprintf() directly instead of XmuSnprintf()Alan Coopersmith
All platforms still supported by X.Org have long had snprintf() Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 12:13:15 +0000