| Age | Commit message (Collapse) | Author |
|---|
|
From the reporter on #xorg-devel:
-!- thrig [thrig@unaffilaited/thrig] has joined #xorg-devel
<thrig> where does the code for bitmap live? there's a crash (or who
knows on some platforms) if you `bitmap -size 42`
|
|
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears 169 out of 240 -Wdiscarded-qualifiers warnings from gcc 7.3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
StripFilename() allocates a new string for its result, so after we're
done with it, free it instead of just losing the pointer to it.
Fixes errors found by Oracle Parfait 1.5.1 bug checking tool:
Error: Memory leak (CWE 401)
Memory leak of pointer basename allocated with StripFilename(filename)
at line 712 of Bitmap.c in function 'XmuWriteBitmapDataToFile'.
basename allocated at line 691 with StripFilename(filename).
basename leaks when i >= data_length at line 702.
Error: Memory leak (CWE 401)
Memory leak of pointer basename allocated with StripFilename(filename)
at line 715 of Bitmap.c in function 'XmuWriteBitmapDataToFile'.
basename allocated at line 691 with StripFilename(filename).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
StripFilename() already allocates a new string for its result,
we don't need to duplicate it and then lose the pointer to the
first one.
Fixes errors found by Oracle Parfait 1.5.1 bug checking tool:
Error: Memory leak (CWE 401)
Memory leak of pointer pointer allocated with StripFilename(filename)
at line 1119 of Bitmap.c in function 'BWReadFile'.
pointer allocated at line 1106 with StripFilename(filename).
pointer leaks when StripFilename(filename) != NULL at line 1106.
Error: Memory leak (CWE 401)
Memory leak of pointer pointer allocated with StripFilename(filename)
at line 1119 of Bitmap.c in function 'BWReadFile'.
pointer allocated at line 1106 with StripFilename(filename).
Error: Memory leak (CWE 401)
Memory leak of pointer pointer allocated with StripFilename(filename)
at line 1222 of Bitmap.c in function 'BWWriteFile'.
pointer allocated at line 1202 with StripFilename(filename).
pointer leaks when StripFilename(filename) != NULL at line 1202.
Error: Memory leak (CWE 401)
Memory leak of pointer pointer allocated with StripFilename(filename)
at line 1222 of Bitmap.c in function 'BWWriteFile'.
pointer allocated at line 1202 with StripFilename(filename).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Bitmap.c:906:17: warning: declaration shadows a local variable [-Wshadow]
unsigned char *image_data;
^
Bitmap.c:799:11: note: previous declaration is here
char *image_data, *buffer_data;
^
Bitmap.c:907:8: warning: declaration shadows a local variable [-Wshadow]
char *buffer_data;
^
Bitmap.c:799:24: note: previous declaration is here
char *image_data, *buffer_data;
^
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Bitmap.c:1246:8: warning: Dereference of null pointer
**str = '\0';
~~~~~~^~~~~~
1 warning generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Found by Parfait 0.5.0.1 bug checking tool:
Leaked X Resource pix
at line 393 of Bitmap.c in function 'BWGetUnzoomedPixmap'.
pix initialized at line 388 with XCreatePixmap(...).
at line 414 of Bitmap.c in function 'BWGetUnzoomedPixmap'.
pix initialized at line 409 with XCreatePixmap(...).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
All platforms still supported by X.Org have long had snprintf()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
|
|
This also uses XORG_CHANGELOG and XORG_CWARNFLAGS, and corrects
make distcheck.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
