summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-07-31Assume C89 signal handlers, returning voidAlan Coopersmith
Removes old #ifdef SIGNALRETURNSINT check that was never defined in autoconf builds, only old Imake builds. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-31Make some more previously global variables into file-scoped staticsAlan Coopersmith
Not used from other source files, so no need to export them Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-31Remove unused global variable gotFirstSaveAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-31unifdef macII - drop support for A/UX 2.0Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-31Make various helper & callback functions private to session.cAlan Coopersmith
Nothing else ever called them, so no reason to export them. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: <wharms@bfs.de>
2013-07-31Convert remaining K&R function declarations to C89 styleAlan Coopersmith
Many existing function declarations were C89, and headers all use C89 prototypes, but a few function declarations had been left in the old style. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: <wharms@bfs.de>
2013-07-31Use (void) to declare functions that take no arguments, instead of ()Alan Coopersmith
It's time for C89. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: <wharms@bfs.de>
2013-07-18Syntax error in recent twm commitColin Harrison
twm needs a typo/syntax correction following a recent commit. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-18Constification cleanup - fix dozens of gcc warningsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-06-19Don't rely on the ability to set tab stops.Eric S. Raymond
2012-11-30Fix SEGV if CreateColormapWindow() returns NULL.Egbert Eich
twm can segfault when it cannot collect attribute information on a window that has been destroyed before it got a chance to collect it's attributes. twm seems to assume that it is always able to collect this information and disregards the error if the function that attempts to collect it fails and CreateColormapWindow() returns NULL. If this happens correct number_cmap_windows to prevent a SEGV later on due to an incorrect setting. Signed-off-by: Egbert Eich <eich@freedesktop.org>
2011-11-19Terminate execl() arguments with NULL instead of 0Alan Coopersmith
Makes sure that a full 64-bits of 0 is passed in 64-bit builds, and clears gcc warning of: menus.c: In function ‘System’: menus.c:2344:2: warning: missing sentinel in function call Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-07-27twm 1.0.7twm-1.0.7Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-07-14Whitespace fixes in src filesAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-07-12Replace most sprintf calls with snprintfAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-06-15config: layout the C flags for better readabilityGaetan Nadon
Group pre-processor flags under AM_CPPFLAGS Might as well do the rest of the file. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-06-15man: use Autoconf provided $(SED)Gaetan Nadon
Use platform appropriate version of sed. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-06-15config: rm is about removal, not generationGaetan Nadon
Automake: AM_V_at as a prefix to commands that should not output anything in silent mode Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-06-15deftwmrc.c is not required in MAINTAINERCLEANFILESGaetan Nadon
Automake takes care of that as it is part of BUILT_SOURCES Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-06-15lex & yacc: only header file needs to be in BUILT_SOURCESGaetan Nadon
http://www.gnu.org/software/automake/manual/automake.html#Yacc-and-Lex This completes reversal of commit ea03b6bcd1045dfc0d6947e4858de8994d61170b The Makefile generates a valid "gram.h: gram.c" rule. The Makefile already has gram.c gram.h and lex.c in the maintainer-clean-generic target. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-05-12Add extra sanity checking to avoid possible NULL dereferencesJeremy Huddleston
menus.c:569:10: warning: Access to field 'func' results in a dereference of a null pointer (loaded from variable 'ActiveItem') if (ActiveItem->func != F_TITLE && !ActiveItem->state) ^~~~~~~~~~ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
2011-05-12Add sanity checking to avoid a possible NULL dereferenceJeremy Huddleston
menus.c:934:26: warning: Access to field 'fore' results in a dereference of a null pointer (loaded from variable 'cur') cur->hi_back = cur->fore = f3.pixel; ~~~ ^ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
2011-05-12Address a possible NULL pointer dereferenceJeremy Huddleston
menus.c:523:24: warning: Access to field 'w' results in a dereference of a null pointer (loaded from variable 'ActiveMenu') if (XFindContext(dpy, ActiveMenu->w, ScreenContext, &context_data) == 0) ^~~~~~~~~~ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
2011-05-11Mark Done() as _X_NORETURNJeremy Huddleston
list.c:103:11: warning: Access to field 'next' results in a dereference of a null pointer (loaded from variable 'nptr') nptr->next = *list_head; ~~~~ ^ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2011-05-11Silence uninitialized warningJeremy Huddleston
session.c: In function 'ReadWinConfigFile': session.c:554: warning: 'version' may be used uninitialized in this function Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2011-05-11LP64: Fix formatting for DEBUG printfJeremy Huddleston
add_window.c: In function 'AddWindow': add_window.c:169: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'Window' Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2011-05-11Fix: menus.c:2374: warning: implicit declaration of function `putenv`Alan Coopersmith
Ensure _GNU_SOURCE is defined on Linux builds before including <stdlib.h> so the prototype is exposed in the header properly. https://bugs.freedesktop.org/show_bug.cgi?id=32696 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Julien Cristau <jcristau@debian.org>
2011-05-10Remove unused fallback implementation of putenv()Alan Coopersmith
NOPUTENV was never defined in a modular build, probably because putenv() is a standard function in Unix98 / SUSv2, and goes back to at least SVR2 and 4.3BSD-Reno. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr> Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
2011-03-04man: replace hard coded section number with __appmansuffix__Gaetan Nadon
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-05Fix many gcc strict-aliasing warningsAlan Coopersmith
menus.c:518: warning: dereferencing type-punned pointer will break strict-aliasing rules and many more of the same message at different lines Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-05twm 1.0.6twm-1.0.6Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-11-24config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERSAlan Coopersmith
Regroup AC statements under the Autoconf initialization section. Regroup AM statements under the Automake initialization section. Add missing AC_CONFIG_SRCDIR Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-11-01config: replace AC_CHECK_FILE with test -fMartin Jansa
* AC_CHECK_FILE doesn't work for cross compilation Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-10-30twm 1.0.5twm-1.0.5Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-30Sun's copyrights now belong to OracleAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-06Purge cvs tags.Jesse Adkins
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
2010-09-23config: upgrade to util-macros 1.8 for additional man page supportAlan Coopersmith
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS The value of MAN_SUBST is the same for all X.Org packages. Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS The existing statement can now be removed from the configuration file. Use automake provided $(AM_V_GEN) and XORG_DEFAULT_OPTIONS provided $(SED) Enables silent rule and use platform appropriate version of sed. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-22Silence build of deftwmrc.c with AM_V_GENAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-22system.twmrc doesn't need to be in both EXTRA_DIST & dist_rc_DATAAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-22config: Remove unnecessary calls from configure.acAlan Coopersmith
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-22Use AC_CHECK_FUNCS / default name for mkstempAlan Coopersmith
No longer need to maintain #ifdef compatibility with the names used in the monolith Imakefiles. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-22config: update AC_PREREQ statement to 2.60Gaetan Nadon
Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-08-06Fill in COPYING file with copyright notices from source codeAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-07-17config: allow to build tarball when yacc is missingGaetan Nadon
Autoconf does not handle this scenario as well as Automake does. If gram.c is already there, do not abort the configuration if yacc is missing as it is not needed. If both gram.c and yacc are missing, abort configuration. Yacc is a required tool to build the package. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-06-04config: add check for yacc to insure it is installed #27973Gaetan Nadon
Unlike other macros AC_PROG_YACC sets the YACC variable to "yacc" as a last resort, even if no programs have been found. Improve error checking by issuing an error message if yacc is not found. The module cannot build anyway. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-01-14Update Sun license notices to current X.Org standard formAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2009-11-26Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILESGaetan Nadon
Now that the INSTALL file is generated. Allows running make maintainer-clean.
2009-10-28INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206Gaetan Nadon
Add missing INSTALL file. Use standard GNU file on building tarball README may have been updated Remove AUTHORS file as it is empty and no content available yet. Remove NEWS file as it is empty and no content available yet.
2009-10-27Deploy the new XORG_DEFAULT_OPTIONS #24242Gaetan Nadon
This macro aggregate a number of existing macros that sets commmon X.Org components configuration options. It shields the configuration file from future changes.
2009-10-26Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432Gaetan Nadon
ChangeLog filename is known to Automake and requires no further coding in the makefile.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 03:54:11 +0000