Age | Commit message (Collapse) | Author |
|
patch submitted by Preston Crow
modified to check if xrandr development header/library is available
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
obsolete and less portable
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
|
|
https://gitlab.freedesktop.org/xorg/app/twm/issues/4
patch submitted by Jes Bodi Klinke
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
fixed in that case.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
twm.c:544:20: warning: assignment discards ‘const’ qualifier from
pointer target type [-Wdiscarded-qualifiers]
Scr->iconmgr.name = "TWM";
^
twm.c:545:25: warning: assignment discards ‘const’ qualifier from
pointer target type [-Wdiscarded-qualifiers]
Scr->iconmgr.icon_name = "Icons";
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
${rcdir} is ${datadir}/X11/twm by default, but can be overridden when
running make. If it is overridden, then the code should read from the
same place as where "make rcdir=FOO install" puts the file.
(Obviously overriding rcdir= for "make install" requires overriding it
for "make" as well. But at least this way it's possible to get it to
work. :-) )
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by Oracle's Parfait 2.2 static analyzer:
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer sc allocated with malloc(32)
at line 421 of src/util.c in function 'InsertRGBColormap'.
sc allocated at line 397 with malloc(32)
sc leaks when replace != 0 at line 405.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by Oracle's Parfait 2.2 static analyzer:
Error: Use after free
Use after free [use-after-free] (CWE 416):
Use after free of pointer Scr
at line 421 of src/util.c in function 'InsertRGBColormap'.
Invalid pointer accessible via global Scr at line 105 of src/twm.c
maps escapes to sc->maps at line 419 of src/util.c in function 'InsertRGBColormap'
maps freed with XFree at line 406
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
It now always allocates memory, so remove some unnecessary checks.
While here, improve handling of an error case.
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
This will almost always select the wrong fontset and use wrong metrics.
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Was originally added in 1993 with the comment:
make f.exec do the right thing to get working xterms under Solaris2.
Doesn't seem to be needed any more on modern Solaris.
As a bonus, gets rid of error found by Oracle Parfait 1.5.1 that
if the execl() call fails, the function falls through and returns
an uninitialized value for status and then both parent & child
go back to running the same code.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Since Xlib prior to 1.6 didn't always clear values on failure, don't
assume they're safe to use unless we succeeded.
Reported by Oracle Parfait 1.5.1:
Error: Uninitialised memory (CWE 456)
Possible access to uninitialised memory '&nPixels'
at line 963 of src/parse.c in function 'put_pixel_on_root'.
&nPixels allocated at line 953.
Possible access to uninitialised memory '&retProp'
at line 962 of src/parse.c in function 'put_pixel_on_root'.
&retProp allocated at line 954.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Laurent Carlier <lordheavym@gmail.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Fix Automake warning: AC_OUTPUT should be used without arguments.
www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Files
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Removes old #ifdef SIGNALRETURNSINT check that was never defined in
autoconf builds, only old Imake builds.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Not used from other source files, so no need to export them
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Nothing else ever called them, so no reason to export them.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: <wharms@bfs.de>
|
|
Many existing function declarations were C89, and headers all use C89
prototypes, but a few function declarations had been left in the old
style.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: <wharms@bfs.de>
|