Age | Commit message (Collapse) | Author |
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Removes old #ifdef SIGNALRETURNSINT check that was never defined in
autoconf builds, only old Imake builds.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Not used from other source files, so no need to export them
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Nothing else ever called them, so no reason to export them.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: <wharms@bfs.de>
|
|
Many existing function declarations were C89, and headers all use C89
prototypes, but a few function declarations had been left in the old
style.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: <wharms@bfs.de>
|
|
It's time for C89.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: <wharms@bfs.de>
|
|
twm needs a typo/syntax correction following a recent commit.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
twm can segfault when it cannot collect attribute information on
a window that has been destroyed before it got a chance to collect
it's attributes.
twm seems to assume that it is always able to collect this information
and disregards the error if the function that attempts to collect it
fails and CreateColormapWindow() returns NULL.
If this happens correct number_cmap_windows to prevent a SEGV later
on due to an incorrect setting.
Signed-off-by: Egbert Eich <eich@freedesktop.org>
|
|
Makes sure that a full 64-bits of 0 is passed in 64-bit builds, and
clears gcc warning of:
menus.c: In function ‘System’:
menus.c:2344:2: warning: missing sentinel in function call
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Group pre-processor flags under AM_CPPFLAGS
Might as well do the rest of the file.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Use platform appropriate version of sed.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Automake:
AM_V_at as a prefix to commands that should not output anything in silent mode
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Automake takes care of that as it is part of BUILT_SOURCES
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
http://www.gnu.org/software/automake/manual/automake.html#Yacc-and-Lex
This completes reversal of commit ea03b6bcd1045dfc0d6947e4858de8994d61170b
The Makefile generates a valid "gram.h: gram.c" rule.
The Makefile already has gram.c gram.h and lex.c in the
maintainer-clean-generic target.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
menus.c:569:10: warning: Access to field 'func' results in a dereference of a null pointer (loaded from variable 'ActiveItem')
if (ActiveItem->func != F_TITLE && !ActiveItem->state)
^~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
menus.c:934:26: warning: Access to field 'fore' results in a dereference of a null pointer (loaded from variable 'cur')
cur->hi_back = cur->fore = f3.pixel;
~~~ ^
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
menus.c:523:24: warning: Access to field 'w' results in a dereference of a null pointer (loaded from variable 'ActiveMenu')
if (XFindContext(dpy, ActiveMenu->w, ScreenContext, &context_data) == 0)
^~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
list.c:103:11: warning: Access to field 'next' results in a dereference of a null pointer (loaded from variable 'nptr')
nptr->next = *list_head;
~~~~ ^
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
session.c: In function 'ReadWinConfigFile':
session.c:554: warning: 'version' may be used uninitialized in this function
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
add_window.c: In function 'AddWindow':
add_window.c:169: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'Window'
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Ensure _GNU_SOURCE is defined on Linux builds before including <stdlib.h>
so the prototype is exposed in the header properly.
https://bugs.freedesktop.org/show_bug.cgi?id=32696
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
|
|
NOPUTENV was never defined in a modular build, probably because putenv()
is a standard function in Unix98 / SUSv2, and goes back to at least
SVR2 and 4.3BSD-Reno.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
|
|
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
menus.c:518: warning: dereferencing type-punned pointer will break strict-aliasing rules
and many more of the same message at different lines
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Add missing AC_CONFIG_SRCDIR
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
* AC_CHECK_FILE doesn't work for cross compilation
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
|
|
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.
Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
The existing statement can now be removed from the configuration file.
Use automake provided $(AM_V_GEN) and XORG_DEFAULT_OPTIONS provided $(SED)
Enables silent rule and use platform appropriate version of sed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
No longer need to maintain #ifdef compatibility with the names used in
the monolith Imakefiles.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|