Age | Commit message (Collapse) | Author |
|
obsolete and less portable
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
It now always allocates memory, so remove some unnecessary checks.
While here, improve handling of an error case.
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Was originally added in 1993 with the comment:
make f.exec do the right thing to get working xterms under Solaris2.
Doesn't seem to be needed any more on modern Solaris.
As a bonus, gets rid of error found by Oracle Parfait 1.5.1 that
if the execl() call fails, the function falls through and returns
an uninitialized value for status and then both parent & child
go back to running the same code.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
It's time for C89.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: <wharms@bfs.de>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Makes sure that a full 64-bits of 0 is passed in 64-bit builds, and
clears gcc warning of:
menus.c: In function ‘System’:
menus.c:2344:2: warning: missing sentinel in function call
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
menus.c:569:10: warning: Access to field 'func' results in a dereference of a null pointer (loaded from variable 'ActiveItem')
if (ActiveItem->func != F_TITLE && !ActiveItem->state)
^~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
menus.c:934:26: warning: Access to field 'fore' results in a dereference of a null pointer (loaded from variable 'cur')
cur->hi_back = cur->fore = f3.pixel;
~~~ ^
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
menus.c:523:24: warning: Access to field 'w' results in a dereference of a null pointer (loaded from variable 'ActiveMenu')
if (XFindContext(dpy, ActiveMenu->w, ScreenContext, &context_data) == 0)
^~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Ensure _GNU_SOURCE is defined on Linux builds before including <stdlib.h>
so the prototype is exposed in the header properly.
https://bugs.freedesktop.org/show_bug.cgi?id=32696
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
|
|
menus.c:518: warning: dereferencing type-punned pointer will break strict-aliasing rules
and many more of the same message at different lines
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
|
|
|
|
Export ImUtil.h to match modular tree install.
Define SVR4 to 1 to avoid warning about redefining to different values.
Include missing headers to clear more compiler warnings.
|
|
xc/programs/twm/cursor.c
xc/programs/twm/events.c
xc/programs/twm/gc.c
xc/programs/twm/gram.y
xc/programs/twm/iconmgr.c
xc/programs/twm/icons.c
xc/programs/twm/list.c
xc/programs/twm/menus.c
xc/programs/twm/parse.c
xc/programs/twm/resize.c
xc/programs/twm/twm.c
//bugs.freedesktop.org/show_bug.cgi?id=2566) attachment #2083
(https://bugs.freedesktop.org/attachment.cgi?id=2083) ANSI-fy twm
window manager code. The conversion preserves the comments which
annotate variables and function arguments (these have been moved into
doxygen(esque?) "stubs" above each function. Patch by Mike Owens
<etc@filespanker.com>.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|