Age | Commit message (Collapse) | Author |
|
math.c: In function ‘negf’:
math.c:474:36: warning: ‘snprintf’ output may be truncated before the last
format character [-Wformat-truncation=]
474 | snprintf(tmp, sizeof(tmp), "-%s", dispstr);
| ^
math.c:474:5: note: ‘snprintf’ output between 2 and 33 bytes into a
destination of size 32
474 | snprintf(tmp, sizeof(tmp), "-%s", dispstr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xcalc/-/merge_requests/13>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Adds translations with NumLock modifier active, since removing "None"
from the existing translations would make shifted keys enter numbers
instead of doing the operations corresponding to the shifted character.
Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=173314
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
This was used with old versions of lint to stop warnings about
unused return values.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Update red keys on right and make the hexadecimal digit keys white too
Fixes: 19eb8ce ("TI mode: correct key color highlighting")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
The information previously listed here didn't match what is present in
the source code or the COPYING file, and the X(7) man page doesn't list
any license information as this had claimed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Decimal number key mapping in XCalc-color was offset after adding
the bitwise ops & base conversion keys in commit c4f1bdb1
Fixes: #2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Reported by gcc 7.3:
actions.c: In function ‘quit’:
actions.c:414:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (ev->type == ClientMessage && ev->xclient.data.l[0] != wm_delete_window)
^~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Reported by gcc 7.3:
xcalc.c: In function ‘Syntax’:
xcalc.c:322:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (i=0; i < XtNumber(Options); i++)
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears up 58 of 62 gcc -Wdiscarded-qualifiers warnings in the xcalc build
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
These operations implicitly truncate their parameters, and result to
integers:
* not
* and
* or
* xor
* shl
* shr
* mod
* trunc
Base 2 was left out of the base conversion code intentionally as it
would require making the UI at least one third wider.
Attempts to change base with negative values will simply display
"error." Note that with larger numbers, the result may be inaccurate
due to rounding.
I've also bound the Return key to the equal() action.
Signed-off-by: Tim Hentenaar <tim@hentenaar.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Gets rid of these warnings:
math.c:707:24: warning: this statement may fall through [-Wimplicit-fallthrough=]
case kSQR: flagINV = !flagINV; /* fall through to */
~~~~~~~~^~~~~~~~~~
math.c:708:3: note: here
case kSQRT: if (flagINV) dnum=dnum*dnum;
^~~~
math.c:711:24: warning: this statement may fall through [-Wimplicit-fallthrough=]
case k10X: flagINV = !flagINV; /* fall through to */
~~~~~~~~^~~~~~~~~~
math.c:712:3: note: here
case kLOG: if (flagINV) dnum=pow(10.0,dnum);
^~~~
math.c:715:24: warning: this statement may fall through [-Wimplicit-fallthrough=]
case kEXP: flagINV = !flagINV; /* fall through to */
~~~~~~~~^~~~~~~~~~
math.c:716:3: note: here
case kLN: if (flagINV) dnum=exp(dnum);
^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
math.c: In function ‘numeric’:
math.c:267:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentat
ion]
if ((int) strlen(dispstr) >= MAXDISP)
^~
math.c:270:5: note: ...this statement, but the latter is misleadingly indented a
s if it were guarded by the ‘if’
switch (keynum){
^~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Now that Imake SIGNALRETURNSINT has been removed, the signal handler
function return type can only be void.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Drops use of Imake's obsolete SIGNALRETURNSINT.
Reviewd-by: Mark Kettenis <kettenis@openbsd.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Resolves many gcc warnings of the form:
actions.c: In function ‘add’:
actions.c:142:35: warning: declaration of ‘e’ shadows a global declaration
actions.c:57:13: warning: shadowed declaration is here [-Wshadow]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Flagged by clang:
math.c:33:9: warning: macro is not used [-Wunused-macros]
#define min(a,b) ((a) < (b) ? (a) : (b))
^
math.c:34:9: warning: macro is not used [-Wunused-macros]
#define max(a,b) ((a) > (b) ? (a) : (b))
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Use the new M_E symbol from math.h and fix and a value of the same
accuracy if it's necessary to redefine M_E.
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Use the new M_PI symbol from math.h and fix and a value of the same
accuracy if it's necessary to redefine M_PI.
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Use services provided by XORG_MANPAGE_SECTIONS.
Use standard Makefile for man pages.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|