| Age | Commit message (Collapse) | Author |
|---|
|
From gcc 14.1:
Eyes.c: In function ‘EyesConfigure’:
Eyes.c:132:45: warning: ‘calloc’ sizes specified with ‘sizeof’ in the
earlier argument and not in the later argument [-Wcalloc-transposed-args]
132 | EyeConfiguration *c = calloc(sizeof(EyeConfiguration), 1);
| ^~~~~~~~~~~~~~~~
Eyes.c:132:45: note: earlier argument should specify number of elements,
later size of each element
Eyes.c: In function ‘Initialize’:
Eyes.c:409:36: warning: ‘calloc’ sizes specified with ‘sizeof’ in the
earlier argument and not in the later argument [-Wcalloc-transposed-args]
409 | TPoint *pupils = calloc(sizeof(TPoint), config->count);
| ^~~~~~
Eyes.c:409:36: note: earlier argument should specify number of elements,
later size of each element
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xeyes/-/merge_requests/8>
|
|
This removes the assumption that an xeyes instance displays just a pair
of eyes, and instead allows future developers to implement different
kinds of ocular layouts.
Currently, the ocular layout system only allows for specifying offsets,
but a future change might also make different parts of the eye geometry
configurable: size of different elements, padding, etc.
Signed-off-by: Serge Bazanski <q3k@q3k.org>
|
|
Fixes gcc warning:
Eyes.c:54:15: warning: redundant redeclaration of ‘hypot’ [-Wredundant-decls]
extern double hypot(double, double);
^~~~~
since it's already declared in <math.h>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Add (char *) casts to initializers in Xt structs.
Remove unused variables.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
|
v2:
We only need Xi version 2.0, not 2.2
Suggested-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Keith Packard <keithp@keithp.com>
|
|
This makes updating the eyes nicely vblank synchronized.
v2:
Ensure extensions exist before calling query_version
These calls add calls to xcb_get_extension_data before calling
query_version calls, as those calls will mark the connection
with an error if made against an X server without the
extension present.
Suggested-by: Uli Schlachter <psychon@znc.in>
v3:
check the 'present' field in the return from
xcb_get_extension_data; the xcb_get_extension_data call will
always succeed (save for out of memory), the only way to tell
if the extension is supported in the target X server is to
test the 'present' field in the query extension reply value.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
|
|
Distance mapping makes more efficient use of eye space.
Signed-off-by: Dylan Simon <dylan@dylex.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
|
|
By transforming the eyes’s space when calculating where to place the
pupils, the code effectively assumed that EYE_HEIGHT == EYE_WIDTH.
Make this assumption explicit and remove calculations which
are therefore unnecessary.
Clean up related code and, consequently, reduced redraw time
and tearing.
Signed-off-by: Dylan Simon <dylan@dylex.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
|
|
introduced by dbb8401026c421d64a2962e6ac6eb900f6dc141e
Signed-off-by: Dylan Simon <dylan@dylex.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
|
|
Optionally draw all components (except shape) with xrender.
Enabled by default. Xlib rendering can be restored by
"configure --without-xrender" or "xeyes +render".
Signed-off-by: Dylan Simon <dylan@dylex.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
|
|
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
This also uses XORG_CHANGELOG and XORG_CWARNFLAGS, corrects
make distcheck and all gcc 4.3 and sparse warnings.
|
|
|
|
|
|
|
|
|
|
|
|
|
