| Age | Commit message (Collapse) | Author |
|---|
|
Originally fixed for Solaris in August 2000 by Jay Hobson under
Sun bug 4256527 "Internationalize xfontsel"
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
When given the "-scaled" option fetch the actual screen resolution and
add that to the list of available resolutions for the resX and resY
menus.
I.e. If the pattern contains '*' for the resX and resY fields (i.e.
instead of '0') then we wil end up with the menu containing "0, 100,
NNN", which makes for a really good demonstration of how scaling of
fonts without knowing the true screen resolution can lead to very wonky
results. Even if the values in the pattern are '0' you still get the
true DPI as an option in the menus.
When you specify a size for a scalable font, you should use points,
never pixels. Points are a physical unit of measurement. There are
always 72 points per inch. Never more or less. So to scale fonts
properly on a screen the scaler needs to know the resolution of the
display in pixels per inch in order to render text at a measurable
physical point size. In the current X11 world it is still up to the
user to correctly specify the actual screen resolution when requesting a
scalable font to render text with, and this is now possible to
demonstrate with this change to Xfontsel.
So with the actual correct resolution selected from the resX and resY
menus (and if the resolution figures are accurate and if the display
hasn't been scaled by the hardware or, e.g. XrandR) then choosing any
avaliable point size will show the sample text with a height on the
screen physically matching the chosen point size. To that end the
default pixelSizeList resource has been changed to just "0", as it
should never be changed, and instead the default "pointSizeList"
resource has been extended with a list of reasonable real-world
sample (deci)point sizes.
[also touch up the help text and call exit() to exit main()]
Signed-off-by: Greg A. Woods <woods@robohack.ca>
|
|
It's very tedious to deselect multiple XLFD field names if you want to
start from scratch (it's often easier to relaunch the app). Hence, a
simple reset button can be handy.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears gcc warnings:
xfontsel.c: In function ‘QuitAction’:
xfontsel.c:1477:1: warning: function might be candidate for
attribute ‘noreturn’ [-Wsuggest-attribute=noreturn]
QuitAction(Widget w, XEvent *event, String *params, Cardinal *num_params)
^~~~~~~~~~
xfontsel.c: In function ‘Quit’:
xfontsel.c:1392:6: warning: function might be candidate for
attribute ‘noreturn’ [-Wsuggest-attribute=noreturn]
void Quit(Widget w, XtPointer closure, XtPointer callData)
^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Gets rid of gcc warning:
xfontsel.c: In function ‘GetFontNames’:
xfontsel.c:498:16: warning: declaration of ‘f’ shadows a previous local [-Wshadow]
int maxField, f;
^
xfontsel.c:446:9: note: shadowed declaration is here
int f, field, count;
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears up 32 out of 49 -Wdiscarded-qualifiers warnings from gcc
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Before if you selected a pattern that couldn't load, such as a strange
encoding, the text widget would simply stop updating, giving the user
no feedback that they weren't seeing the selected font, and leaving
repaint turds from menus in the text area. Now we are more clear that
something is wrong, and clean up when menus overlap the text.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Defer creating ParseRec until after we check for numFonts = 0 and return.
Fixes error found by Parfait 0.5.0.2 bug checking tool:
Memory leak of pointer '<unknown>' allocated with XtMalloc(40)
at line 466 of app/xfontsel/xfontsel.c in function 'GetFontNames'.
pointer allocated at line 447 with XtMalloc(40).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
It was included in the initial revision. The bug dates back to 2006, so I
think it's safe to say that this never worked.
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
|
|
This also uses XORG_CHANGELOG and XORG_CWARNFLAGS, corrects
make distcheck and all gcc 4.3 and sparse warnings.
|
|
Ansify functions with K&R prototypes.
Adjust some definitions to match required prototypes.
Declare as static some functions to avoid warnings about missing prototypes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
