From 3172dc7e15b7a249555ca12e24f4a787164a7f8a Mon Sep 17 00:00:00 2001 From: Jeremy Huddleston Sequoia Date: Wed, 11 Jan 2023 21:33:11 -0800 Subject: darwin: Remove bashism from 10-tmpdirs script possible bashism in 10-tmpdirs line 57 (should be >word 2>&1): if ${MKTEMP} -d ${dir} >& /dev/null ; then Fixes: https://github.com/XQuartz/XQuartz/issues/316 Signed-off-by: Jeremy Huddleston Sequoia --- launchd/privileged_startx/10-tmpdirs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/launchd/privileged_startx/10-tmpdirs.cpp b/launchd/privileged_startx/10-tmpdirs.cpp index 4366696..ec79ae4 100755 --- a/launchd/privileged_startx/10-tmpdirs.cpp +++ b/launchd/privileged_startx/10-tmpdirs.cpp @@ -54,7 +54,7 @@ for dir in /tmp/.ICE-unix /tmp/.X11-unix /tmp/.font-unix ; do # Use mktemp rather than mkdir to avoid possible security issue # if $dir exists and is a symlink (ie protect against a race # against the above check) - if ${MKTEMP} -d ${dir} >& /dev/null ; then + if ${MKTEMP} -d ${dir} > /dev/null 2>&1 ; then chmod 1777 $dir chown root:wheel $dir success=1 -- cgit v1.2.3 From 0fb9f76d3f0205298b0d98c5b0a9a09c4e418388 Mon Sep 17 00:00:00 2001 From: ayekat Date: Thu, 12 Jan 2023 22:06:50 +0100 Subject: startx: Assign XSERVERRC to correct userserverrc Also fix same mistake in the startx manpage. Signed-off-by: ayekat --- man/startx.man | 2 +- startx.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/startx.man b/man/startx.man index 2fe952d..1c48a66 100644 --- a/man/startx.man +++ b/man/startx.man @@ -177,7 +177,7 @@ will be used. .TP 25 XSERVERRC This variable should contain the location of an xserver file. If unset, -.I $(HOME)/.xinitrc +.I $(HOME)/.xserverrc or .I __xinitdir__/xserverrc will be used. diff --git a/startx.cpp b/startx.cpp index dfbebe1..c38ff21 100644 --- a/startx.cpp +++ b/startx.cpp @@ -52,7 +52,7 @@ userclientrc=$HOME/.xinitrc sysclientrc=XINITDIR/xinitrc userserverrc=$HOME/.xserverrc -[ -f "${XSERVERRC}" ] && userclientrc="${XSERVERRC}" +[ -f "${XSERVERRC}" ] && userserverrc="${XSERVERRC}" sysserverrc=XINITDIR/xserverrc defaultclient=XTERM defaultserver=XSERVER -- cgit v1.2.3