Use unsigned ints when shifting to create bitmasks

symbols.c:1057:28: portability: Shifting signed 32-bit value by 31 bits
  is implementation-defined behaviour. See condition at line 1049.
  [shiftTooManyBitsSigned]
        radio_groups |= (1 << (tmp.uval - 1));
                           ^
symbols.c:1049:41: note: Assuming that condition 'tmp.uval>32' is not redundant
        if ((tmp.uval < 1) || (tmp.uval > XkbMaxRadioGroups))
                                        ^
symbols.c:1057:28: note: Shift
        radio_groups |= (1 << (tmp.uval - 1));
                           ^
symbols.c:1057:28: warning: Either the condition 'tmp.uval>32' is redundant
  or there is signed integer overflow for expression '1<<(tmp.uval-1)'.
  [integerOverflowCond]
        radio_groups |= (1 << (tmp.uval - 1));
                           ^
symbols.c:1049:41: note: Assuming that condition 'tmp.uval>32' is not redundant
        if ((tmp.uval < 1) || (tmp.uval > XkbMaxRadioGroups))
                                        ^
symbols.c:1057:28: note: Integer overflow
        radio_groups |= (1 << (tmp.uval - 1));
                           ^

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/expr.c b/expr.c
index 56e3988..4ca9820 100644
--- a/expr.c
+++ b/expr.c
@@ -273,7 +273,7 @@ LookupModMask(XPointer priv,
     else if (uStrCaseCmp(str, "none") == 0)
         val_rtrn->uval = 0;
     else if (LookupModIndex(priv, elem, field, type, val_rtrn))
-        val_rtrn->uval = (1 << val_rtrn->uval);
+        val_rtrn->uval = (1U << val_rtrn->uval);
     else if (priv != NULL)
     {
         LookupPriv *lpriv = (LookupPriv *) priv;