Use unsigned ints when shifting to create bitmasks

symbols.c:1057:28: portability: Shifting signed 32-bit value by 31 bits
  is implementation-defined behaviour. See condition at line 1049.
  [shiftTooManyBitsSigned]
        radio_groups |= (1 << (tmp.uval - 1));
                           ^
symbols.c:1049:41: note: Assuming that condition 'tmp.uval>32' is not redundant
        if ((tmp.uval < 1) || (tmp.uval > XkbMaxRadioGroups))
                                        ^
symbols.c:1057:28: note: Shift
        radio_groups |= (1 << (tmp.uval - 1));
                           ^
symbols.c:1057:28: warning: Either the condition 'tmp.uval>32' is redundant
  or there is signed integer overflow for expression '1<<(tmp.uval-1)'.
  [integerOverflowCond]
        radio_groups |= (1 << (tmp.uval - 1));
                           ^
symbols.c:1049:41: note: Assuming that condition 'tmp.uval>32' is not redundant
        if ((tmp.uval < 1) || (tmp.uval > XkbMaxRadioGroups))
                                        ^
symbols.c:1057:28: note: Integer overflow
        radio_groups |= (1 << (tmp.uval - 1));
                           ^

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/keycodes.c b/keycodes.c
index 8e4fe9e..8e431c6 100644
--- a/keycodes.c
+++ b/keycodes.c
@@ -880,8 +880,8 @@ CompileKeycodes(XkbFile * file, XkbFileInfo * result, unsigned merge)
                                   XkbAtomGetString(NULL, ii->name), False);
                 if (xkb->indicators != NULL)
                 {
-                    unsigned bit;
-                    bit = 1 << (ii->ndx - 1);
+                    unsigned bit = 1U << (ii->ndx - 1);
+
                     if (ii->virtual)
                         xkb->indicators->phys_indicators &= ~bit;
                     else