Use temporary buffer for generating Uxxx names to avoid overflow

Instead of sprintf()'ing a 4 character string to a char [4] buffer,
and leaving the trailing '\0' to overwrite into the next entry,
snprintf() to a 5 character temp buffer and memcpy the 4 characters
to the right place.

Fixes parfait errors:
Error: Buffer overflow at xkbcomp-1.0.4/misc.c:393
        in function 'ComputeKbdDefaults' [Standard C Library pattern matching]
       In sprintf related dereference of xkb->names->keys[i].name
        with index not less than '4'
       Destination array size is 4 bytes, data to be written is 4 bytes
Error: Buffer overflow at xkbcomp-1.0.4/misc.c:402
        in function 'ComputeKbdDefaults' [Standard C Library pattern matching]
       In sprintf related dereference of xkb->names->keys[i].name
        with index not less than '4'
       Destination array size is 4 bytes, data to be written is 4 bytes

[This bug was found by the Parfait bug checking tool.
  For more information see http://research.sun.com/projects/parfait ]

Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>

0 files changed, 0 insertions, 0 deletions