Age | Commit message (Collapse) | Author |
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Without the fix xkbcomp may leave a truncated file in the filesystem
if there is not enough disk space. Using the truncated file leads to
problems.
Signed-off-by: Rami Ylimaki <ext-rami.ylimaki@nokia.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
|
Instead of sprintf()'ing a 4 character string to a char [4] buffer,
and leaving the trailing '\0' to overwrite into the next entry,
snprintf() to a 5 character temp buffer and memcpy the 4 characters
to the right place.
Fixes parfait errors:
Error: Buffer overflow at xkbcomp-1.0.4/misc.c:393
in function 'ComputeKbdDefaults' [Standard C Library pattern matching]
In sprintf related dereference of xkb->names->keys[i].name
with index not less than '4'
Destination array size is 4 bytes, data to be written is 4 bytes
Error: Buffer overflow at xkbcomp-1.0.4/misc.c:402
in function 'ComputeKbdDefaults' [Standard C Library pattern matching]
In sprintf related dereference of xkb->names->keys[i].name
with index not less than '4'
Destination array size is 4 bytes, data to be written is 4 bytes
[This bug was found by the Parfait bug checking tool.
For more information see http://research.sun.com/projects/parfait ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
|
|
The default was hardcoded in the Makefile as $(datadir)/share/X11/xkb.
This could cause a problem if you are installing xkbcomp to an alternate
location but want to continue using the system's XKB data.
Signed-off-by: Dan Nicholson <dbn.lists@gmail.com>
|
|
|
|
Remaining warnings are due to macros that check address or vectors
on the stack and auto generated yacc code.
Compiled with default flags and also as:
% make CFLAGS=-DENTRY_TRACKING_ON -DDEBUG_ON -DASSERTIONS_ON
to ensure the "simplification" of code like:
foo.c:
<hash>define DEBUG_VAR foo_VAR
<hash>include "foo.h"
...
foo.h:
<hash>ifdef DEBUG_VAR_NOT_LOCAL
extern
<hash>endif
int DEBUG_VAR;
...
did not change the author's "intended" logic.
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
|
|
|
|
|
|
POSIX.1-1990 is well below the current minimum bar
|
|
|
|
The default type for a key with no levels is ONE_LEVEL.
Let's not overwrite the kt_index with this default type if we have previously
assigned a real type.
Reproduceable by running setxkbmap -layout "ru(phonetic),us", the first group
is assigned ONE_LEVEL and shift stops working.
Red Hat Bug #436626 <https://bugzilla.redhat.com/show_bug.cgi?id=436626>
|
|
|
|
What use is a handler if we only ever use one function anyway?
|
|
|
|
|
|
"Conditional jump or move depends on uninitialised value(s)"
|
|
|
|
|
|
indent -cbi 0 -nprs -nut -npcs -i4 -bli 0 *.c *.h
|
|
|
|
|
|
|
|
|
|
Hey, I wonder if we have XKB files in our directory! I wonder if we
haven't bothered with a structure, and let's try to open a file called
'misc' in someone's home directory! What a surprise, it's not a valid
XKB file! Let's fail miserably!
SURPRISINGLY, THIS IS NOT USEFUL BEHAVIOUR.
|
|
Allows the user to set maps (or whatever) on arbitrary devices.
|
|
|
|
Since it's if (0 || foo), simplify to if (foo).
|
|
<http://bugs.freedesktop.org/show_bug.cgi?id=14185>
|
|
Apparently only yacc generates it.
This reverts commit 3e5b0d615b94c66a2b5a8b3d2e4a04713a442002.
|
|
|
|
|
|
|
|
|
|
Some keynames are less than 3 characters long (not counting the
terminator). We're now also initializing all of the keyName array.
|
|
X.Org Bugzilla #11025 <https://bugs.freedesktop.org/show_bug.cgi?id=11025>
|
|
|
|
|
|
|
|
si.interp.match may be unused, so just clobber it, which means we don't
end up with stuff like LevelOneOnlyMask wandering in.
|
|
Accept negative co-ordinates for geometry, per the spec.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
update to fix bug #5167 (Linux prefers *.1x man pages in man1 subdir)
|