Age | Commit message (Collapse) | Author |
|
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
xlsclients.c:303:47: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
qt_reply = malloc(sizeof(*qt_reply) * cs->list_length);
~ ~~~~^~~~~~~~~~~
xlsclients.c:323:31: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
cs = malloc(sizeof(*cs) + child_count * (sizeof(*cs->prop_cookie) + sizeof(*cs->tree_cookie) + sizeof(*cs->win)));
^~~~~~~~~~~ ~
xlsclients.c:515:38: warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
class_len = wm_class->value_len - name_len;
~ ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
xlsclients.c:515:40: warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
class_len = wm_class->value_len - name_len;
~ ^~~~~~~~
xlsclients.c:514:56: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
name_len = strnlen(res_name, wm_class->value_len) + 1;
~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
xlsclients.c:520:15: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
class_len = strlen(res_class);
~ ^~~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
As suggested by clang:
xlsclients.c:69:1: warning: function 'usage' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
{
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
xlsclients.c: In function ‘show_client_properties’:
xlsclients.c:485:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
485 | for (i = 0; i < command->value_len && charsleft > 0; ) {
| ^
xlsclients.c:488:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
488 | if (i < command->value_len && charsleft > 0) {
| ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
I think these were false positives, as the accesses were all inside
"if (cs->verbose)" checks, matching the initialization case for them,
but this makes gcc stop warning.
xlsclients.c:531:13: warning: ‘wm_class’ may be used uninitialized [-Wmaybe-uninitialized]
531 | free(wm_class);
| ^~~~~~~~~~~~~~
xlsclients.c:440:31: note: ‘wm_class’ was declared here
440 | xcb_get_property_reply_t *wm_class;
| ^~~~~~~~
xlsclients.c:475:35: warning: ‘icon_name’ may be used uninitialized [-Wmaybe-uninitialized]
475 | if (icon_name && icon_name->type)
| ~~~~~~~~~^~~~~~
xlsclients.c:439:31: note: ‘icon_name’ was declared here
439 | xcb_get_property_reply_t *icon_name;
| ^~~~~~~~~
xlsclients.c:527:13: warning: ‘name’ may be used uninitialized [-Wmaybe-uninitialized]
527 | free(name);
| ^~~~~~~~~~
xlsclients.c:438:31: note: ‘name’ was declared here
438 | xcb_get_property_reply_t *name;
| ^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears compiler warnings:
xlsclients.c:253:28: warning: declaration shadows a local variable [-Wshadow]
xcb_get_property_reply_t *reply;
^
xlsclients.c:250:30: note: previous declaration is here
xcb_query_tree_reply_t **reply;
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Add missing AC_CONFIG_SRCDIR([Makefile.am])
Move AC_USE_SYSTEM_EXTENSIONS higher up in Autoconf init section
which must come before XORG_DEFAULT_OPTIONS
Move XORG_DEFAULT_OPTIONS to its usual place with X.Org macros
Note that AC_FUNC_STRNLEN calls AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS)
Comment the strnlen function replacement.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/strlen.html
No functional changes. Following the layout in
http://www.x.org/wiki/NewModuleGuidelines
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
AC_FUNC_STRLEN is one of the functions that call AC_LIBOBJ
which sets $LIBOBJ.
This reverts commit 789a5b42a716b14429c67161147151dd57dd5480.
|
|
Starting at Autoconf 2.53, the use of LIBOBJS is an error.
http://www.gnu.org/software/autoconf/manual/autoconf.html#
AC_005fLIBOBJ-vs-LIBOBJS
There are no system functions to override in this module.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Arnaud Fontaine <arnau@debian.org>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
With commit 223851b6, the atom names from xcb/xproto.h are being used
and xcb-atom is no longer needed.
Signed-off-by: Dan Nicholson <dbn.lists@gmail.com>
Reviewed-by: Jon TURNEY <jon.turney@dronecode.org.uk>
|
|
Those deprecated atom names were removed from xcb/util in commit
2f0334b3eb49fa3a0d6daf6b9dde10e480a5c59f
Found by tinderbox, see:
http://tinderbox.freedesktop.org/builds/2011-03-06-0008/logs/xlsclients/#build
http://tinderbox.freedesktop.org/builds/2011-03-07-0001/logs/xlsclients/#build
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Tested-by: Dan Nicholson <dbn.lists@gmail.com>
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
Use services provided by XORG_MANPAGE_SECTIONS.
Use standard Makefile for man pages.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Using s/[ \t]*$//
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This silences an Autoconf warning
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.
Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
Enables use of platform appropriate version of sed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Fixes 'make distcheck' failure found by tinderbox:
make[2]: *** No rule to make target `xlsclients.1', needed by `all-am'. Stop.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Now that the INSTALL file is generated.
Allows running make maintainer-clean.
|
|
Add missing INSTALL file. Use standard GNU file on building tarball
README may have been updated
Remove AUTHORS file as it is empty and no content available yet.
Remove NEWS file as it is empty and no content available yet.
|
|
ChangeLog filename is known to Automake and requires no further
coding in the makefile.
|
|
Using common defaults will reduce errors and maintenance.
Only the very small or inexistent custom section need periodic maintenance
when the structure of the component changes. Do not edit defaults.
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
|
|
Prevents core dump when display can't be opened
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
|
|
On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote:
> On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote:
> > I noticed an INSTALL file in xlsclients and libXvMC today, and it
> > was quite annoying to work around since 'autoreconf -fvi' replaces
> > it and git wants to commit it. Should these files even be in git?
> > Can I nuke them for the betterment of humanity and since they get
> > created by autoreconf anyways?
>
> See https://bugs.freedesktop.org/show_bug.cgi?id=24206
As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with
AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation
of the INSTALL file. It is also part of the 24206 solution.
|
|
xcb_atom_t and xcb_window_t are both typedef'd as uint32_t.
Since PRI*32 are a C99 feature that may not be available, fallbacks
are provided based on the assumption of a 32-bit int.
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Signed-off-by: Jamey Sharp <jamey@minilop.net>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
|