summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-11-13xlsclients 1.1.5xlsclients-1.1.5Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-24Resolve implicit conversion warnings from clangAlan Coopersmith
xlsclients.c:303:47: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion] qt_reply = malloc(sizeof(*qt_reply) * cs->list_length); ~ ~~~~^~~~~~~~~~~ xlsclients.c:323:31: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion] cs = malloc(sizeof(*cs) + child_count * (sizeof(*cs->prop_cookie) + sizeof(*cs->tree_cookie) + sizeof(*cs->win))); ^~~~~~~~~~~ ~ xlsclients.c:515:38: warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion] class_len = wm_class->value_len - name_len; ~ ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ xlsclients.c:515:40: warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion] class_len = wm_class->value_len - name_len; ~ ^~~~~~~~ xlsclients.c:514:56: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] name_len = strnlen(res_name, wm_class->value_len) + 1; ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ xlsclients.c:520:15: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] class_len = strlen(res_class); ~ ^~~~~~~~~~~~~~~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-24usage: add cold & noreturn attributes to functionAlan Coopersmith
As suggested by clang: xlsclients.c:69:1: warning: function 'usage' could be declared with attribute 'noreturn' [-Wmissing-noreturn] { ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-24Handle -Wsign-compare warningsAlan Coopersmith
xlsclients.c: In function ‘show_client_properties’: xlsclients.c:485:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare] 485 | for (i = 0; i < command->value_len && charsleft > 0; ) { | ^ xlsclients.c:488:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare] 488 | if (i < command->value_len && charsleft > 0) { | ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-24Quiet -Wmaybe-uninitialized warnings from gccAlan Coopersmith
I think these were false positives, as the accesses were all inside "if (cs->verbose)" checks, matching the initialization case for them, but this makes gcc stop warning. xlsclients.c:531:13: warning: ‘wm_class’ may be used uninitialized [-Wmaybe-uninitialized] 531 | free(wm_class); | ^~~~~~~~~~~~~~ xlsclients.c:440:31: note: ‘wm_class’ was declared here 440 | xcb_get_property_reply_t *wm_class; | ^~~~~~~~ xlsclients.c:475:35: warning: ‘icon_name’ may be used uninitialized [-Wmaybe-uninitialized] 475 | if (icon_name && icon_name->type) | ~~~~~~~~~^~~~~~ xlsclients.c:439:31: note: ‘icon_name’ was declared here 439 | xcb_get_property_reply_t *icon_name; | ^~~~~~~~~ xlsclients.c:527:13: warning: ‘name’ may be used uninitialized [-Wmaybe-uninitialized] 527 | free(name); | ^~~~~~~~~~ xlsclients.c:438:31: note: ‘name’ was declared here 438 | xcb_get_property_reply_t *name; | ^~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-24gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-06Build xz tarballs instead of bzip2HEADmasterAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-06gitlab CI: add a basic build testAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-21Update configure.ac bug URL for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-16Update README for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-03-09xlsclients 1.1.4xlsclients-1.1.4Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2017-01-26autogen: add default patch prefixMihail Konev
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2014-05-31Print which option was in error along with usage messageAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-05-31autogen.sh: Honor NOCONFIGURE=1Alan Coopersmith
See http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-05-31configure: Drop AM_MAINTAINER_MODEAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-09-08xlsclients 1.1.3xlsclients-1.1.3Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-19Fix deconstification warnings from gccAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-07-19Add -version flag to print version from PACKAGE_STRINGAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-22Give unique names to the two reply variables in child_infoAlan Coopersmith
Clears compiler warnings: xlsclients.c:253:28: warning: declaration shadows a local variable [-Wshadow] xcb_get_property_reply_t *reply; ^ xlsclients.c:250:30: note: previous declaration is here xcb_query_tree_reply_t **reply; Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-01-25configure.ac: regroup statements and commentGaetan Nadon
Add missing AC_CONFIG_SRCDIR([Makefile.am]) Move AC_USE_SYSTEM_EXTENSIONS higher up in Autoconf init section which must come before XORG_DEFAULT_OPTIONS Move XORG_DEFAULT_OPTIONS to its usual place with X.Org macros Note that AC_FUNC_STRNLEN calls AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS) Comment the strnlen function replacement. http://pubs.opengroup.org/onlinepubs/9699919799/functions/strlen.html No functional changes. Following the layout in http://www.x.org/wiki/NewModuleGuidelines Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2012-01-20Revert "make: remove $(LIBOBJS) dead code"Gaetan Nadon
AC_FUNC_STRLEN is one of the functions that call AC_LIBOBJ which sets $LIBOBJ. This reverts commit 789a5b42a716b14429c67161147151dd57dd5480.
2012-01-20make: remove $(LIBOBJS) dead codeGaetan Nadon
Starting at Autoconf 2.53, the use of LIBOBJS is an error. http://www.gnu.org/software/autoconf/manual/autoconf.html# AC_005fLIBOBJ-vs-LIBOBJS There are no system functions to override in this module. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-05-02xlsclients 1.1.2xlsclients-1.1.2Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-05-02Depend on xcb >= 1.6 for XCB_ATOM_*.Arnaud Fontaine
Signed-off-by: Arnaud Fontaine <arnau@debian.org> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-03-13Drop dependency on xcb-atom/xcb-utilDan Nicholson
With commit 223851b6, the atom names from xcb/xproto.h are being used and xcb-atom is no longer needed. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> Reviewed-by: Jon TURNEY <jon.turney@dronecode.org.uk>
2011-03-07Use XCB_ATOM_* atom names rather than deprecated atom namesJon TURNEY
Those deprecated atom names were removed from xcb/util in commit 2f0334b3eb49fa3a0d6daf6b9dde10e480a5c59f Found by tinderbox, see: http://tinderbox.freedesktop.org/builds/2011-03-06-0008/logs/xlsclients/#build http://tinderbox.freedesktop.org/builds/2011-03-07-0001/logs/xlsclients/#build Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk> Tested-by: Dan Nicholson <dbn.lists@gmail.com> Signed-off-by: Peter Harris <pharris@opentext.com>
2011-01-19config: move man pages into their own directoryGaetan Nadon
Use services provided by XORG_MANPAGE_SECTIONS. Use standard Makefile for man pages. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-13man: replace hard coded man page section with substitution stringsGaetan Nadon
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-13man: remove trailing spaces and tabsGaetan Nadon
Using s/[ \t]*$// Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-12config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERSGaetan Nadon
This silences an Autoconf warning
2010-10-06Purge cvs tags.Jesse Adkins
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
2010-09-24xlsclients 1.1.1xlsclients-1.1.1Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-24config: Remove unnecessary calls from configure.acAlan Coopersmith
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-24config: upgrade to util-macros 1.8 for additional man page supportAlan Coopersmith
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS The value of MAN_SUBST is the same for all X.Org packages. Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS Enables use of platform appropriate version of sed. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-24config: update AC_PREREQ statement to 2.60Gaetan Nadon
Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-06-23strnlen.h should be added to EXTRA_DIST, not overwrite itAlan Coopersmith
Fixes 'make distcheck' failure found by tinderbox: make[2]: *** No rule to make target `xlsclients.1', needed by `all-am'. Stop. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-06-04Add strnlen.h to EXTRA_DISTJeremy Huddleston
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2010-06-03xlsclients 1.1.0xlsclients-1.1.0Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2009-11-26Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILESGaetan Nadon
Now that the INSTALL file is generated. Allows running make maintainer-clean.
2009-10-28INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206Gaetan Nadon
Add missing INSTALL file. Use standard GNU file on building tarball README may have been updated Remove AUTHORS file as it is empty and no content available yet. Remove NEWS file as it is empty and no content available yet.
2009-10-28Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432Gaetan Nadon
ChangeLog filename is known to Automake and requires no further coding in the makefile.
2009-10-28.gitignore: use common defaults with custom section # 24239Gaetan Nadon
Using common defaults will reduce errors and maintenance. Only the very small or inexistent custom section need periodic maintenance when the structure of the component changes. Do not edit defaults.
2009-10-27Add Copyright/License notice for xcb & strnlen changes to COPYINGAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2009-10-21Fix check for xcb_connect failureAlan Coopersmith
Prevents core dump when display can't be opened Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2009-10-21xlsclients is not a GNU project, so declare it foreign.Gaetan Nadon
On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote: > On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote: > > I noticed an INSTALL file in xlsclients and libXvMC today, and it > > was quite annoying to work around since 'autoreconf -fvi' replaces > > it and git wants to commit it. Should these files even be in git? > > Can I nuke them for the betterment of humanity and since they get > > created by autoreconf anyways? > > See https://bugs.freedesktop.org/show_bug.cgi?id=24206 As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation of the INSTALL file. It is also part of the 24206 solution.
2009-10-21Use inttypes.h for correct printf formatsYaakov Selkowitz
xcb_atom_t and xcb_window_t are both typedef'd as uint32_t. Since PRI*32 are a C99 feature that may not be available, fallbacks are provided based on the assumption of a 32-bit int. Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Signed-off-by: Jamey Sharp <jamey@minilop.net>
2009-10-20Add implementation of strnlen for systems without this functionJeremy Huddleston
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
2009-10-19Rewrite xlsclients to use XCB, avoiding many (many) round tripsPeter Harris
This version spends bandwidth to reduce latency; in particular, it aggressively calls query_tree before the answer to get_property(WM_STATE) is available. Even on my local box, this version is 4-10 times faster (30ms typical, vs 200ms typical for Xlib). I get similar results over the local network. At least one person reports this version takes less than 2 seconds over ssh, vs over a minute for the Xlib version (~30x faster). Reviewed-by: Jamey Sharp <jamey@minilop.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-21 14:33:16 +0000