| Age | Commit message (Collapse) | Author |
|---|
|
xlsclients.c:303:47: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
qt_reply = malloc(sizeof(*qt_reply) * cs->list_length);
~ ~~~~^~~~~~~~~~~
xlsclients.c:323:31: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
cs = malloc(sizeof(*cs) + child_count * (sizeof(*cs->prop_cookie) + sizeof(*cs->tree_cookie) + sizeof(*cs->win)));
^~~~~~~~~~~ ~
xlsclients.c:515:38: warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
class_len = wm_class->value_len - name_len;
~ ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
xlsclients.c:515:40: warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
class_len = wm_class->value_len - name_len;
~ ^~~~~~~~
xlsclients.c:514:56: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
name_len = strnlen(res_name, wm_class->value_len) + 1;
~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
xlsclients.c:520:15: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
class_len = strlen(res_class);
~ ^~~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
As suggested by clang:
xlsclients.c:69:1: warning: function 'usage' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
{
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
xlsclients.c: In function ‘show_client_properties’:
xlsclients.c:485:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
485 | for (i = 0; i < command->value_len && charsleft > 0; ) {
| ^
xlsclients.c:488:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
488 | if (i < command->value_len && charsleft > 0) {
| ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
I think these were false positives, as the accesses were all inside
"if (cs->verbose)" checks, matching the initialization case for them,
but this makes gcc stop warning.
xlsclients.c:531:13: warning: ‘wm_class’ may be used uninitialized [-Wmaybe-uninitialized]
531 | free(wm_class);
| ^~~~~~~~~~~~~~
xlsclients.c:440:31: note: ‘wm_class’ was declared here
440 | xcb_get_property_reply_t *wm_class;
| ^~~~~~~~
xlsclients.c:475:35: warning: ‘icon_name’ may be used uninitialized [-Wmaybe-uninitialized]
475 | if (icon_name && icon_name->type)
| ~~~~~~~~~^~~~~~
xlsclients.c:439:31: note: ‘icon_name’ was declared here
439 | xcb_get_property_reply_t *icon_name;
| ^~~~~~~~~
xlsclients.c:527:13: warning: ‘name’ may be used uninitialized [-Wmaybe-uninitialized]
527 | free(name);
| ^~~~~~~~~~
xlsclients.c:438:31: note: ‘name’ was declared here
438 | xcb_get_property_reply_t *name;
| ^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears compiler warnings:
xlsclients.c:253:28: warning: declaration shadows a local variable [-Wshadow]
xcb_get_property_reply_t *reply;
^
xlsclients.c:250:30: note: previous declaration is here
xcb_query_tree_reply_t **reply;
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
With commit 223851b6, the atom names from xcb/xproto.h are being used
and xcb-atom is no longer needed.
Signed-off-by: Dan Nicholson <dbn.lists@gmail.com>
Reviewed-by: Jon TURNEY <jon.turney@dronecode.org.uk>
|
|
Those deprecated atom names were removed from xcb/util in commit
2f0334b3eb49fa3a0d6daf6b9dde10e480a5c59f
Found by tinderbox, see:
http://tinderbox.freedesktop.org/builds/2011-03-06-0008/logs/xlsclients/#build
http://tinderbox.freedesktop.org/builds/2011-03-07-0001/logs/xlsclients/#build
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Tested-by: Dan Nicholson <dbn.lists@gmail.com>
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
Prevents core dump when display can't be opened
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
|
|
xcb_atom_t and xcb_window_t are both typedef'd as uint32_t.
Since PRI*32 are a C99 feature that may not be available, fallbacks
are provided based on the assumption of a 32-bit int.
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Signed-off-by: Jamey Sharp <jamey@minilop.net>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
|
|
This version spends bandwidth to reduce latency; in particular, it
aggressively calls query_tree before the answer to get_property(WM_STATE) is
available.
Even on my local box, this version is 4-10 times faster (30ms typical, vs
200ms typical for Xlib). I get similar results over the local network.
At least one person reports this version takes less than 2 seconds over ssh,
vs over a minute for the Xlib version (~30x faster).
Reviewed-by: Jamey Sharp <jamey@minilop.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
