| Age | Commit message (Collapse) | Author |
|---|
|
xvinfo.c: In function ‘main’:
xvinfo.c:99:23: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
for (j = 0; j < nadaptors; j++) {
^
xvinfo.c:129:31: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
for (k = 0; k < ainfo[j].num_formats; k++, format++) {
^
xvinfo.c:198:31: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
for (n = 0; n < nencode; n++) {
^
xvinfo.c:207:35: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
for (n = 0; n < nencode; n++) {
^
xvinfo.c:222:35: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
for (n = 0; n < nencode; n++) {
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=74227
aka https://gitlab.freedesktop.org/xorg/app/xvinfo/issues/1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
If one of the query functions fail, xvinfo does not properly handle
these cases and will most likely run into a segmentation fault due
to accessing uninitialized variables (which includes pointers).
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Starts at 0 and increments to count encodings - should never go negative.
Fixes clang warnings:
xvinfo.c:184:31: warning: implicit conversion changes signedness: 'int' to
'unsigned int' [-Wsign-conversion]
if (nencode - ImageEncodings) {
~ ^~~~~~~~~~~~~~
xvinfo.c:186:39: warning: implicit conversion changes signedness: 'int' to
'unsigned int' [-Wsign-conversion]
nencode - ImageEncodings);
~ ^~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Should be impossible to overflow with previous sprintf code, but
still safer to avoid bugs if something changes in the future.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Suggested by clang:
xvinfo.c:125:25: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
else
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=9665 .
|
|
|
|
|
|
|
|
|
|
|
|
|
