diff options
| author | Gaetan Nadon <memsize@videotron.ca> | 2011-06-28 17:13:30 -0400 |
|---|---|---|
| committer | Gaetan Nadon <memsize@videotron.ca> | 2011-07-05 16:39:33 -0400 |
| commit | cb6818b6230ca43ddaabfb8f16feaef9ae3ef68e (patch) | |
| tree | 5655a8906908858bc59e6c0bfff624f5ff33bd29 /test/Makefile.am | |
| parent | bb604aca58f9c718601a22290176e201e92d36ab (diff) | |
Revert "build: collapse all Makefile.am files into a single non-recursive one."
This reverts commit 39afe69ad7d2258d4043044d1283bd6e311e48da.
1. For such a small module, the build time improvement is most likely
negligible. At least, I'd like to see some timings proving it's
worthiness before seeing the patch go back in.
2. This kind of change would need a thorough review. The need to
operate the build from a single toplevel Makefile is a significant
change. The two most noticeable issues for me are that collapsing all
the Makefiles could easily cause namespacing issues with the
variables, and operating on files outside the current directory can
introduce subtle bugs. I feel that the non-recursive style is
generally less robust than the standard recursive make scheme.
3. It's unlike all the other X.org modules. This isn't a showstopper
for me, but the recursive style is well understood here and you've
beaten all the modules into a consistent format that makes build bugs
unique to specific modules less likely.
Acked-by: Dan Nicholson <dbn.lists@gmail.com>
To give a concrete example for #3 above, the 175 man pages are much
easier maintained using a very similar makefile in the man directory
of all X.Org module.
The cost of maintaining a single makefile is much higher. Every target
in the makefile has to be reviewed and tested when changes are made.
Not everyone has the all the skills to handle widely different targets
such as man pages, DocBook/XML, librairies, C code, distribution hooks,
and so on.
Acked-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Diffstat (limited to 'test/Makefile.am')
| -rw-r--r-- | test/Makefile.am | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/test/Makefile.am b/test/Makefile.am new file mode 100644 index 0000000..5dd8cdb --- /dev/null +++ b/test/Makefile.am @@ -0,0 +1,15 @@ +if ENABLE_UNIT_TESTS +AM_CPPFLAGS = -I$(top_srcdir)/src -I$(top_srcdir)/include +AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS) +fake_syms = fake-symbols.c fake-symbols.h + +if BUILD_EVENTCOMM +noinst_PROGRAMS = eventcomm-test + +eventcomm_test_SOURCES = eventcomm-test.c\ + $(top_srcdir)/src/eventcomm.c \ + $(fake_syms) +endif + +TESTS = $(noinst_PROGRAMS) +endif |