summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-06-10drop compat with ancient Linux kernelmasterEnrico Weigelt, metux IT consult
linux-2.6.30 was released 15 years ago - doesn't seem to be necessary to still support such ancient kernels. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2024-05-14bump minimal xorg version to 1.18Enrico Weigelt, metux IT consult
1.18 was released a decade ago, so it seems reasonable stop supporting older ones. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/18>
2024-05-12Take care of -Wempty-body warning from call to empty PS2DBG macroAlan Coopersmith
ps2comm.c: In function ‘ps2_synaptics_get_packet’: ps2comm.c:477:49: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] 477 | PS2DBG("faked reset received\n"); | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/17>
2024-05-12Clear 9 of 9 -Wimplicit-fallthrough warningsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/17>
2024-05-12Quiet -Wredundant-decls from xorg/os.h fallbacks for timingsafe_memcmpAlan Coopersmith
The Xorg headers provide their own version of timingsafe_memcmp for platforms that don't have them in libc yet, but rely on configure to set HAVE_* defines to determine if they should be defined in the headers. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/17>
2024-05-12Fix -Wold-style-declaration warningAlan Coopersmith
synaptics.c:143:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] 143 | const static struct { | ^~~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/17>
2024-05-12Raise minimum supported Xserver version from 1.12 to 1.15Alan Coopersmith
Drops support for ABI_XINPUT_VERSION < 20, including removing support for driver-side coordinate scaling, since the X server handles it now. Xserver 1.15 was released in Dec. 2013. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05Handle a -Wstrict-prototypes/-Wold-style-definition pair of warningsAlan Coopersmith
synclient.c:196:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] 196 | dp_init() | ^~~~~~~ synclient.c: In function ‘dp_init’: synclient.c:196:1: warning: old-style function definition [-Wold-style-definition] Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05Handle 5 -Wmissing-prototypes warningsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05Fix 185 -Wdiscarded-qualifiers warningsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05Add X.Org's standard C warning flags to AM_CFLAGSAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-12-02configure: updates to quiet obsolete macro warningsAlan Coopersmith
Clears autoconf warnings: configure.ac:38: warning: The macro 'AC_PROG_LIBTOOL' is obsolete. configure.ac:38: You should run autoupdate. aclocal.m4:3515: AC_PROG_LIBTOOL is expanded from... configure.ac:38: the top level configure.ac:68: warning: The macro 'AC_HELP_STRING' is obsolete. configure.ac:68: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:68: the top level configure.ac:78: warning: The macro 'AC_HELP_STRING' is obsolete. configure.ac:78: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:78: the top level libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, libtoolize: and rerunning libtoolize and aclocal. libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-10-01gitlab CI: ensure libtool is installed in build containerAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-09gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-10xf86-input-synaptics 1.9.2xf86-input-synaptics-1.9.2Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-16Convert remaining source files from ISO-8859-1 to UTF-8Alan Coopersmith
Most were already converted. Fixes error raised by FlawFinder in CI: Error: encoding error in ./src/synaptics.c 'utf-8' codec can't decode byte 0xa9 in position 16: invalid start byte Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-16gitlab CI: add a basic build testAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-16Fix spelling/wording issuesAlan Coopersmith
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-16Build xz tarballs instead of bzip2Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-04-09synclient: allow negative/large values for AreaLeftEdge etc.Pip Cet
2020-07-28eventcomm: fix compile with pre-time64 kernelsAriadne Conill
2020-07-22eventcomm: use 64-bit time safe accessors instead of timeval directlyAriadne Conill
when building on a 32-bit host with 64-bit time_t, using the input_event and input_event_usec accessors are necessary to deal with translation.
2019-02-11Use fabs() instead of abs() on double values.Matthieu Herrb
Silences clang warnings. Signed-off-by: Matthieu Herrb <matthieu@herrb.eu> Reviewed-by: Walter Harms <wharms@bfs.de> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2018-11-25Update configure.ac bug URL for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-18Update README for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-05-29synaptics 1.9.1xf86-input-synaptics-1.9.1Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2018-05-15eventcomm: if we get a read error other than EAGAIN, remove the fdPeter Hutterer
Otherwise poll() keeps on triggering on our fd until udev gets around to notifying the server that the device is in some state of deadness. Meanwhile, the input thread is busy filling the log up with "Read error" messages. Great way to test file systems and their capacity to handle out of space scenarios but otherwise a bit pointless. Those FS developers should write their own tests instead of relying on the synaptics driver! Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Adam Jackson <ajax@redhat.com>
2017-10-26Replace SA_ONESHOT with the more portable SA_RESETHAND.Luca Castagnini
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-08-17Drop HandleTouches - it's a noopPeter Hutterer
With the removal of touch events in 0a4cf80a00663, this function is a noop. It merely counted the number of touches but discarded the result. And UpdateTouchState does the update anyway. https://bugs.freedesktop.org/show_bug.cgi?id=102209 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen: add default patch prefixMihail Konev
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-11-18synaptics 1.9.0xf86-input-synaptics-1.9.0Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-10-09synaptics 1.8.99.2xf86-input-synaptics-1.8.99.2Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-09-15Remove unused fraction calculationsPeter Hutterer
hw.x and the motion history are integers so our deltas are always integers. It's a bit pointless to split them into the fractional and integral part. obsolete since defc1d008e5674306a or so Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-08-17eventcomm: don't ever probe if a device is setPeter Hutterer
If opening the fd fails we still need to fail the device. This is particularly the case when a device disappears before we can open it - the current code wouldn't exit but instead switch to auto-probe touchpad devices on the system. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
2016-08-08syndaemon: enable touchpad when pressing a modifier comboAnton Lindqvist
When ignoring modifiers, ensure the touchpad is enabled once a modifier key is pressed disregarding any previous key press that caused the touchpad to be disabled. Signed-off-by: Anton Lindqvist <anton.lindqvist@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-06-02Support XINPUT ABI version 23Peter Hutterer
Use input_lock/input_unlock calls instead of SIGIO functions Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-05-23conf: rename to 70-synaptics.confStefan Dirsch
Bump up the synaptics driver to 70, so it get's preferred over libinput, which was dropped down to 60. The synaptics driver is more of a leaf package than libinput (which covers a multitude of device types) and can be removed by default. When specifically installed by the user, the synaptics driver should override the system default. Similar to what was done for wacom configuration file. https://bugzilla.suse.com/show_bug.cgi?id=979554 Signed-off-by: Stefan Dirsch <sndirsch@suse.de> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-04-29Revert MaxDoubleTapTime back to 180Peter Hutterer
Fallout from 90c6d7fc60f3db1bd9db1c7702062fcaef3b3352 where it got changed to 100ms. This is too short for triple-tap-and-drag gestures so revert it to the previous value. https://bugs.freedesktop.org/show_bug.cgi?id=95171 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-04-29synaptics 1.8.99.1xf86-input-synaptics-1.8.99.1Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-04-27eventcomm: fix typo checking for two-finger scrollingPeter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-08-12Drop touch events from the driverPeter Hutterer
This was a bad idea. No-one seems to use this and it gives us little benefits. To even get this feature a number of other features need to be turned off (like two-finger scrolling and tapping). Many of these are enabled by default, if they are disabled a client stack with full touchpad gesture support could in theory support true touchpad gestures. This has never happened. Drop the touch events from the synaptics driver. This allows us to switch the touchpad fully over to look like a relative device, thus also removing the bug that changes the touchpad speed whenever a monitor is added/removed in. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
2015-08-12eventcomm: ignore key repeat eventsPeter Hutterer
Usually doesn't happen, but the evtest output in https://bugs.freedesktop.org/show_bug.cgi?id=90392 actually has repeat events for the button. Ignore them if they happen. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-03-25eventcomm: ignore fake and broken MT devicesPeter Hutterer
An MT device without X/Y is not a touchpad. And neither are fake MT devices. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
2015-03-24eventcomm: prevent possibly division by zeroPeter Hutterer
This came up as a kernel bug, but it's valid to create uinput devices with a min == max range for x/y. Technically valid, but effectively useless, so catch it, complain and hobble on along. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
2015-03-18Revert "Support the new Lenovo X1 Carbon 3rd trackpoint buttons"Peter Hutterer
This reverts commit 064445364b4775b25ba49c2250b22b169f291147. The Lenovo *50 series, including the X1 Carbon 3rd always require multiple kernel patches to enable the touchpad buttons. This patch in synaptics only addresses the re-routing of the top buttons. The final iteration of the kernel patches also route the trackpoint buttons through the trackpoint device, rendering this patch unnecessary. These patches are queued for 4.0. See kernel patch series up to commit cdd9dc195916ef5644cfac079094c3c1d1616e4c Author: Benjamin Tissoires <benjamin.tissoires@redhat.com> Date: Sun Mar 8 22:35:41 2015 -0700 Input: synaptics - re-route tracksticks buttons on the Lenovo 2015 series Currently in Dmitry's for-linus branch. Distributions running older kernels or the kernel stable series which has partial backports of the above patch series are encouraged to leave the 0644453 commit in and undo this revert. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
2015-03-06conf: add Lenovo T450s and W451 to rulesPeter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-02-18Add a delay between the second button down-up event of double tapsGabriele Mazzotta
Some applications ignore the second tap of double taps because of the lack of a delay between the button down and button up events. Prevent this by replacing the transition from TS_2B to TS_START with a transition from TS_2B to TS_SINGLETAP that emits only a button down event. The button up event will be emitted when transitioning from TS_SINGLETAP to TS_START. In addition, decrease the default value of MaxDoubleTapTime from 180 ms to 100 ms in order to make double taps faster. Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-01-30Support the new Lenovo X1 Carbon 3rd trackpoint buttonsPeter Hutterer
This device has the trackpoint buttons wired up to the touchpad to send BTN_0, BTN_1 and BTN_2 for left, right, middle. This conflicts with previous touchpads that used those event codes for dedicated scroll buttons. Add an option HasTrackpointButtons that can be set via a xorg.conf.d snippets. This option is not intended as a user-set option, rather we expect distributions to ship some conglomerate of udev/hal rules with xorg.conf snippets that take effect. If the option is set, we look at the three affected buttons at the beginning of HandleState and send button events immediately for them. The HW state is reset to neutral and other processing continues. This saves us from having to synchronize these buttons with software buttons (also present on this device), tapping, etc. Since the buttons are physically different and (mentally) associated with the trackpoint device we also don't need to worry about having finger motion event correctly synced up with the button presses - it's acceptable to send the presses before the motion events. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Tested-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
2015-01-16Update machine state diagramGabriele Mazzotta
The diagram didn't entirely reflect the current state of the code. Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-04 08:27:25 +0000