summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichel Dänzer <michel.daenzer@amd.com>2018-12-20 18:44:24 +0100
committerMichel Dänzer <michel@daenzer.net>2018-12-28 12:03:59 +0100
commit189b6facb3988c00c96d970f8c13ed8d58fa3998 (patch)
tree3fa97af97fceb1cf4575202c9d6befea3dfa9af7
parent06957e3067b9eb38d30b32d98a07895399f4cb36 (diff)
Use drm_abort_one in drm_queue_handler
At this point, we've already established that e->handler is NULL, no need to check again in drm_queue_handle_one. This also makes it clearer what's happening. (Ported from amdgpu commit eda571222f5a6be47f8897e82d85199bb9d95251)
-rw-r--r--src/radeon_drm_queue.c28
1 files changed, 14 insertions, 14 deletions
diff --git a/src/radeon_drm_queue.c b/src/radeon_drm_queue.c
index ea78e8e2..ebc6a5b6 100644
--- a/src/radeon_drm_queue.c
+++ b/src/radeon_drm_queue.c
@@ -72,6 +72,19 @@ radeon_drm_queue_handle_one(struct radeon_drm_queue_entry *e)
free(e);
}
+/*
+ * Abort one queued DRM entry, removing it
+ * from the list, calling the abort function and
+ * freeing the memory
+ */
+static void
+radeon_drm_abort_one(struct radeon_drm_queue_entry *e)
+{
+ xorg_list_del(&e->list);
+ e->abort(e->crtc, e->data);
+ free(e);
+}
+
static void
radeon_drm_queue_handler(struct xorg_list *signalled, unsigned int frame,
unsigned int sec, unsigned int usec, void *user_ptr)
@@ -82,7 +95,7 @@ radeon_drm_queue_handler(struct xorg_list *signalled, unsigned int frame,
xorg_list_for_each_entry_safe(e, tmp, &radeon_drm_queue, list) {
if (e->seq == seq) {
if (!e->handler) {
- radeon_drm_queue_handle_one(e);
+ radeon_drm_abort_one(e);
break;
}
@@ -174,19 +187,6 @@ radeon_drm_queue_alloc(xf86CrtcPtr crtc, ClientPtr client,
}
/*
- * Abort one queued DRM entry, removing it
- * from the list, calling the abort function and
- * freeing the memory
- */
-static void
-radeon_drm_abort_one(struct radeon_drm_queue_entry *e)
-{
- xorg_list_del(&e->list);
- e->abort(e->crtc, e->data);
- free(e);
-}
-
-/*
* Abort drm queue entries for a client
*
* NOTE: This keeps the entries in the list until the DRM event arrives,