From fcc89d26600a57317007035fa720915e8a2ade81 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Wed, 9 Nov 2011 12:25:43 +0000 Subject: sna: Safety first; make all flinked bo unreusable Signed-off-by: Chris Wilson --- src/sna/kgem.c | 1 + src/sna/sna_dri.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/sna/kgem.c b/src/sna/kgem.c index 8ef57834..22149cef 100644 --- a/src/sna/kgem.c +++ b/src/sna/kgem.c @@ -1800,6 +1800,7 @@ uint32_t kgem_bo_flink(struct kgem *kgem, struct kgem_bo *bo) * on the buffer, and *presuming* they do not pass it on to a third * party, we track the lifetime accurately. */ + bo->reusable = false; return flink.name; } diff --git a/src/sna/sna_dri.c b/src/sna/sna_dri.c index d21cfb12..f0fcb94c 100644 --- a/src/sna/sna_dri.c +++ b/src/sna/sna_dri.c @@ -152,7 +152,6 @@ static struct kgem_bo *sna_pixmap_set_dri(struct sna *sna, /* The bo is outside of our control, so presume it is written to */ priv->gpu_bo->needs_flush = true; - priv->gpu_bo->reusable = false; priv->gpu_bo->gpu = true; /* We need to submit any modifications to and reads from this @@ -202,7 +201,6 @@ sna_dri_create_buffer(DrawablePtr drawable, pixmap = get_drawable_pixmap(drawable); pixmap->refcnt++; bo = sna_pixmap_set_dri(sna, pixmap); - bo->reusable = true; bpp = pixmap->drawable.bitsPerPixel; DBG(("%s: attaching to front buffer %dx%d [%p:%d]\n", __FUNCTION__, @@ -953,7 +951,6 @@ static void set_pixmap(struct sna *sna, DRI2BufferPtr buffer, PixmapPtr pixmap) priv->pixmap->refcnt--; priv->pixmap = pixmap; priv->bo = sna_pixmap_set_dri(sna, pixmap); - priv->bo->reusable = true; buffer->name = kgem_bo_flink(&sna->kgem, priv->bo); buffer->pitch = priv->bo->pitch; } -- cgit v1.2.3