summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDevin J. Pohly <djpohly+xorg@gmail.com>2012-02-15 13:42:22 -0500
committerMatt Turner <mattst88@gmail.com>2012-02-15 14:32:14 -0500
commit977327e998347f2833632be59b47f0ec7b941188 (patch)
treefb12de877c179a183ffea0ed53b5b66a0df47d44
parentdcd27a9c69a73214471f5c92ad6ed6b892ec9fbd (diff)
Fix segfaults on tip popups
When XAW_INTERNATIONALIZATION isn't defined, some uninitialized stack data was being passed to XtGetValues. This makes it not do that. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46124 Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Devin J. Pohly <djpohly+xorg@gmail.com>
-rw-r--r--src/Tip.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/Tip.c b/src/Tip.c
index 5f54d14..5542fc5 100644
--- a/src/Tip.c
+++ b/src/Tip.c
@@ -606,8 +606,10 @@ TipTimeoutCallback(XtPointer closure, XtIntervalId *id)
#ifdef XAW_INTERNATIONALIZATION
info->tip->tip.international = False;
XtSetArg(args[1], XtNinternational, &info->tip->tip.international);
-#endif
XtGetValues(winfo->widget, args, 2);
+#else
+ XtGetValues(winfo->widget, args, 1);
+#endif
TipLayout(info);
TipPosition(info);