summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-03-24Avoid integer overflowMarkus Steinborn
Found at http://gitorious.org/xaw3d/xaw3d/commit/3ba3e52454bb684a73601ec91e2c274e776f711a Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-03-24Correct XtNthumbProc usageMarkus Steinborn
This ugly piece of magic was copied from libXaw, and now scrollbars will work slightly less incorrectly than they did before. Found at http://gitorious.org/xaw3d/xaw3d/commit/4ec68aebffbdc406139f880f92b6c18b835af6d4 Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-03-14Fix use-after-free in DestroyAllIMMatt Turner
Fixes segmentation fault when closing gv. Found at http://gitorious.org/xaw3d/xaw3d/commit/23b3ca50395f180cba4a923eb8827dcc961629da Fixes: https://bugs.gentoo.org/show_bug.cgi?id=406487 Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com> Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-02-29Fix parameters of FloatInRangeMatt Turner
Introduced in f6cd786d1. Reported-by: Jean-Pierre Demailly <Jean-Pierre.Demailly@ujf-grenoble.fr> Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-02-15libXaw3d 1.6.1libXaw3d-1.6.1Matt Turner
Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-02-15Include MultiSrc.h in AllWidgets.cMatt Turner
AsciiText.h doesn't include MultiSrc.h when internationalization is disabled, so dcd27a9c69a was breaking the build. Also fix a typo introduced in the same commit Xaw -> Xaw3d. Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-02-15Fix segfaults on tip popupsDevin J. Pohly
When XAW_INTERNATIONALIZATION isn't defined, some uninitialized stack data was being passed to XtGetValues. This makes it not do that. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46124 Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Devin J. Pohly <djpohly+xorg@gmail.com>
2012-02-01Add multiSink and multiSrc to AllWidgets.cMatt Turner
Noticed when comparing with libXaw's AllWidgets.c.
2012-02-01Include WidgetNode.h from AllWidgets.hMatt Turner
Makes these two files closer to the libXaw originals. Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-02-01Include headers instead of using extern definitionsMatt Turner
Caught a mistake in SmeThreeD.h: smeThreeDWidgetClass was declared instead of smeThreeDObjectClass. Also fixes redundant redeclaration warnings. Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-02-01Make --enable-internationalization defaultGaetan Nadon
libXaw3d-1.5 was built with internationalization by default and software such as gv and xterm require it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45153 Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-01-24Include XAW3D_CPPFLAGS in xaw3d.pc CflagsMatt Turner
Software depending on libXaw3d seems to require this. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45144 Reviewed-by: Gaetan Nadon <memsize@videotron.ca> Signed-off-by: Matt Turner <mattst88@gmail.com>
2012-01-22Build fix for int-pointer cast errorsJeremy Huddleston
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-01-22Cleanup shadow declarationsJeremy Huddleston
Box.c:265:10: warning: declaration shadows a local variable [-Wshadow] int i = bbw->composite.num_children; ^ Box.c:166:15: note: previous declaration is here Cardinal i; ^ 1 warning generated. Form.c:809:9: warning: declaration shadows a local variable [-Wshadow] Widget w = *childP; ^ Form.c:793:24: note: previous declaration is here XawFormDoLayout(Widget w, ^ 1 warning generated. Viewport.c:627:24: warning: declaration shadows a local variable [-Wshadow] if (!needshoriz) CheckHoriz(); ^ Viewport.c:605:14: note: expanded from macro 'CheckHoriz' Widget bar = w->viewport.horiz_bar; \ ^ Viewport.c:620:14: note: previous declaration is here Widget bar = w->viewport.vert_bar; ^ 1 warning generated. Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-01-22Include <stdlib.h> for abs()Jeremy Huddleston
Tip.c:336:9: error: implicit declaration of function 'abs' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ksy += abs(ext->max_ink_extent.y); ^ 1 error generated. Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-01-21libXaw3d 1.6libXaw3d-1.6Matt Turner
Signed-off-by: Matt Turner <mattst88@gmail.com>
2011-10-09Remove worthless isupper/islower checksMatt Turner
Was toupper() *really* expensive when this was written? :) Also, initialize action_type with toupper(), since the check immediately following assumes that its value is uppercase. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Matt Turner <mattst88@gmail.com>
2011-10-09Remove unused variable 'i'Matt Turner
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Matt Turner <mattst88@gmail.com>
2011-10-09Include stdlib.h for abs()Matt Turner
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Matt Turner <mattst88@gmail.com>
2011-10-06Define call_data to 0 in NotifyScroll()Guillem Jover
Fixes gcc warning: Scrollbar.c: In function 'NotifyScroll': Scrollbar.c:950:12: warning: 'call_data' may be used uninitialized in this function [-Wuninitialized] Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
2011-10-06Use intptr_t instead of int when casting from and to XtPointerGuillem Jover
Fixes gcc warnings: Scrollbar.c: In function 'NotifyScroll': Scrollbar.c:955:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Text.c: In function 'HScroll': Text.c:1274:41: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Text.c: In function 'VScroll': Text.c:1431:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] TextPop.c: In function 'DoSearch': TextPop.c:808:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] TextPop.c: In function 'Replace': TextPop.c:942:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Viewport.c: In function 'ScrollUpDownProc': Viewport.c:866:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
2011-10-06Only use variable t in MoveThumb() on XAW_ARROW_SCROLLBARSGuillem Jover
Fixes gcc warning: Scrollbar.c: In function 'MoveThumb': Scrollbar.c:1006:16: warning: variable 't' set but not used [-Wunused-but-set-variable] Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
2011-10-06Remove unused labelGuillem Jover
Fixes gcc warning: laygram.c: In function 'LayYYparse': laygram.y:242:7: warning: label 'unary' defined but not used [-Wunused-label] Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
2011-10-06Disable unused input and unput lex functionsGuillem Jover
Fixes gcc warnings: laylex.c:1316:17: warning: 'yyunput' defined but not used [-Wunused-function] laylex.c:1357:16: warning: 'input' defined but not used [-Wunused-function] Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Guillem Jover <guillem@hadrons.org>
2011-09-19Fix a couple of unused variable warningsMatt Turner
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Matt Turner <mattst88@gmail.com>
2011-09-19Fix a couple unused function warningsMatt Turner
Functions were only called inside ifdef blocks, but were defined outside. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Matt Turner <mattst88@gmail.com>
2011-09-17Add LayYYWrap() prototype to LayYY.hAlan Coopersmith
Fixes gcc warning: laygram.y:259:5: warning: no previous prototype for 'LayYYwrap' Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matt Turner <mattst88@gmail.com>
2011-09-17Fix several unused variable warningsAlan Coopersmith
All but one are due to variables defined outside #ifdef's but only used inside #ifdef'ed code blocks. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matt Turner <mattst88@gmail.com>
2011-09-17Remove %defines declaration for compatibility with yacc.Matthieu Herrb
The -d flag is used for bison/yacc and has the same effect. Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-09-16Strip trailing whitespaceAlan Coopersmith
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-09-08Make WriteToFile take constified argumentsAlan Coopersmith
Fixes compiler warning: "AsciiSrc.c", line 858: warning: argument #2 is incompatible with prototype: prototype: pointer to char : "AsciiSrc.c", line 118 argument : pointer to const char Has to use _XtString (#define char *) instead of String (typedef char *) to correctly be a pointer to const chars instead of a const pointer to chars. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matt Turner <mattst88@gmail.com>
2011-09-08Add LayYY.h header for common definitions of lex/yacc created functionsAlan Coopersmith
Ensures all sources use consistent types and provides central place to add _X_HIDDEN tags to avoid exporting these as part of the API/ABI. Also fixes: "laygram.c", line 1363: warning: implicit function declaration: LayYYlex "laygram.c", line 1777: warning: implicit function declaration: LayYYerror Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matt Turner <mattst88@gmail.com>
2011-09-08Fix distcheck by changing doc_DATA to dist_doc_DATAAlan Coopersmith
Oops. Helps to include the docs in the tarball if you want to install them. Reported-by: Gaetan Nadon <memsize@videotron.ca> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-07Update README.XAW3D for X.Org releaseAlan Coopersmith
List X.Org as current maintainers instead of D. J. Hawkey Jr. Replace Imakefile configuration instructions with configure flags Remove sections about building in an old X11R5 or R6 monolithic tree. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matt Turner <mattst88@gmail.com>
2011-09-07Distribute & install src/README.XAW3DAlan Coopersmith
The previous maintainer strongly recommended providing this file with the library as the authoritative documentation for the libXaw3d API. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matt Turner <mattst88@gmail.com>
2011-09-07Add xext to required modules for Shape extension callsAlan Coopersmith
Without this, strict linkers like Solaris ld & gold would fail with: Undefined first referenced symbol in file XShapeQueryExtension .libs/Command.o (symbol belongs to implicit dependency libXext.so.0) Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
2011-09-07Use -p instead of %parser for compatibility with older bison & yaccAlan Coopersmith
The %name-prefix "prefix" syntax was introduced in bison 2.3b and is not supported in older bison and yacc parsers. Without this fix, bison 2.3 (older than 2.3b) gives the cryptic error: .../src/laygram.y:1.14-20: syntax error, unexpected string, expecting = Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Tested-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-04Template.c: use #include <X11/Xaw3d/TemplateP.h>Gaetan Nadon
rather than #include "TemplateP.h". Acked-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-04Add conditional include config.h to source files as done in libXawGaetan Nadon
Expections: TexTr.c, sharedlib.c ans generated lex and yacc C code. XawI18n.h needs HAVE_WCTYPE_H and HAVE_WCHAR_H. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-03Fix build after f28531a33d1f28bc86626b3013ef7857b564647fYaakov Selkowitz
Reviewed-by: Gaetan Nadon <memsize@videotron.ca> Tested-by: Gaetan Nadon <memsize@videotron.ca> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-01Label: Fix nested extern declaration warningsYaakov Selkowitz
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Acked-by: Matt Turner <mattst88@gmail.com>
2011-09-01Fix incompatible vfunc pointer warningsYaakov Selkowitz
AsciiSink.c:132:41: warning: initialization from incompatible pointer type AsciiSink.c:135:41: warning: initialization from incompatible pointer type AsciiSink.c:137:41: warning: initialization from incompatible pointer type Vendor.c:199:24: warning: initialization from incompatible pointer type Vendor.c:269:24: warning: initialization from incompatible pointer type Vendor.c:284:24: warning: initialization from incompatible pointer type Viewport.c:143:3: warning: initialization from incompatible pointer type MultiSink.c:160:41: warning: initialization from incompatible pointer type MultiSink.c:162:41: warning: initialization from incompatible pointer type Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Acked-by: Matt Turner <mattst88@gmail.com>
2011-09-01XawIm: Fix old-style function definitionsYaakov Selkowitz
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Acked-by: Gaetan Nadon <memsize@videotron.ca> Acked-by: Matt Turner <mattst88@gmail.com>
2011-09-01MultiSrc: Fix old-style function definitionsYaakov Selkowitz
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Acked-by: Gaetan Nadon <memsize@videotron.ca> Acked-by: Matt Turner <mattst88@gmail.com>
2011-09-01MultiSink: Fix old-style function definitionsYaakov Selkowitz
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Acked-by: Gaetan Nadon <memsize@videotron.ca> Acked-by: Matt Turner <mattst88@gmail.com>
2011-09-01Add missing AC_CONFIG_HEADERSGaetan Nadon
This is a requirement for all modules. www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-01Include Xaw3dP.h using #include <X11/Xaw3d/Xaw3dP.h>Gaetan Nadon
All published Xaw3d header file are included this way. The -I directive to include/X11/Xaw3d is removed which will alert developers not to include header files with quotes unless they are in the /src directory. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-01Rename XAW3D_CFLAGS to XAW3D_CPPFLAGS as it contains preprocessor options onlyGaetan Nadon
This will also prevent confusion as it is not obtained from PKG_CHECK_MODULES but follows its naming convention. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-01Move compiler flags from AM_CPPFLAGS to AM_CFLAGSGaetan Nadon
AM_CPPFLAGS should only contain preprocessor directives like -I -D. The various *_CFLAGS may contain compiler flags as they are obtained from pkg-config Cflags variable. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-01lex and yacc: add error checking when yacc is missingGaetan Nadon
This configuration snippet is copied from app/twm and xgc. It handles the case when yacc tool is missing but yacc generated code in the tarball can be used. Unlike other macros AC_PROG_YACC sets the YACC variable to "yacc" as a last resort, even if no programs have been found. Improve error checking by issuing an error message if yacc is not found. The module cannot build anyway, unless from a published tarball. If laygram.c is already there, do not abort the configuration if yacc is missing as it is not needed. If both generated code and yacc are missing, abort configuration. Yacc is a required tool to build the package. The test for YACC_INST is cross-compiling friendly. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-21 18:06:03 +0000