Age | Commit message (Collapse) | Author |
|
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
AsciiText.h doesn't include MultiSrc.h when internationalization is
disabled, so dcd27a9c69a was breaking the build. Also fix a typo
introduced in the same commit Xaw -> Xaw3d.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
When XAW_INTERNATIONALIZATION isn't defined, some uninitialized stack
data was being passed to XtGetValues. This makes it not do that.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46124
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Devin J. Pohly <djpohly+xorg@gmail.com>
|
|
Noticed when comparing with libXaw's AllWidgets.c.
|
|
Makes these two files closer to the libXaw originals.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Caught a mistake in SmeThreeD.h: smeThreeDWidgetClass was declared
instead of smeThreeDObjectClass.
Also fixes redundant redeclaration warnings.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
libXaw3d-1.5 was built with internationalization by default and software
such as gv and xterm require it.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45153
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Software depending on libXaw3d seems to require this.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45144
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Box.c:265:10: warning: declaration shadows a local variable [-Wshadow]
int i = bbw->composite.num_children;
^
Box.c:166:15: note: previous declaration is here
Cardinal i;
^
1 warning generated.
Form.c:809:9: warning: declaration shadows a local variable [-Wshadow]
Widget w = *childP;
^
Form.c:793:24: note: previous declaration is here
XawFormDoLayout(Widget w,
^
1 warning generated.
Viewport.c:627:24: warning: declaration shadows a local variable [-Wshadow]
if (!needshoriz) CheckHoriz();
^
Viewport.c:605:14: note: expanded from macro 'CheckHoriz'
Widget bar = w->viewport.horiz_bar; \
^
Viewport.c:620:14: note: previous declaration is here
Widget bar = w->viewport.vert_bar;
^
1 warning generated.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Tip.c:336:9: error: implicit declaration of function 'abs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ksy += abs(ext->max_ink_extent.y);
^
1 error generated.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Was toupper() *really* expensive when this was written? :)
Also, initialize action_type with toupper(), since the check immediately
following assumes that its value is uppercase.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Fixes gcc warning:
Scrollbar.c: In function 'NotifyScroll':
Scrollbar.c:950:12: warning: 'call_data' may be used uninitialized in this function [-Wuninitialized]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warnings:
Scrollbar.c: In function 'NotifyScroll':
Scrollbar.c:955:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Text.c: In function 'HScroll':
Text.c:1274:41: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Text.c: In function 'VScroll':
Text.c:1431:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
TextPop.c: In function 'DoSearch':
TextPop.c:808:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
TextPop.c: In function 'Replace':
TextPop.c:942:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Viewport.c: In function 'ScrollUpDownProc':
Viewport.c:866:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warning:
Scrollbar.c: In function 'MoveThumb':
Scrollbar.c:1006:16: warning: variable 't' set but not used [-Wunused-but-set-variable]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warning:
laygram.c: In function 'LayYYparse':
laygram.y:242:7: warning: label 'unary' defined but not used [-Wunused-label]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warnings:
laylex.c:1316:17: warning: 'yyunput' defined but not used [-Wunused-function]
laylex.c:1357:16: warning: 'input' defined but not used [-Wunused-function]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Functions were only called inside ifdef blocks, but were defined
outside.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Fixes gcc warning:
laygram.y:259:5: warning: no previous prototype for 'LayYYwrap'
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
All but one are due to variables defined outside #ifdef's but only
used inside #ifdef'ed code blocks.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
The -d flag is used for bison/yacc and has the same effect.
Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Fixes compiler warning:
"AsciiSrc.c", line 858: warning: argument #2 is incompatible with prototype:
prototype: pointer to char : "AsciiSrc.c", line 118
argument : pointer to const char
Has to use _XtString (#define char *) instead of String (typedef char *) to
correctly be a pointer to const chars instead of a const pointer to chars.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
Ensures all sources use consistent types and provides central place
to add _X_HIDDEN tags to avoid exporting these as part of the API/ABI.
Also fixes:
"laygram.c", line 1363: warning: implicit function declaration: LayYYlex
"laygram.c", line 1777: warning: implicit function declaration: LayYYerror
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
Oops. Helps to include the docs in the tarball if you want to install them.
Reported-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
|
|
List X.Org as current maintainers instead of D. J. Hawkey Jr.
Replace Imakefile configuration instructions with configure flags
Remove sections about building in an old X11R5 or R6 monolithic tree.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
The previous maintainer strongly recommended providing this file with
the library as the authoritative documentation for the libXaw3d API.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
Without this, strict linkers like Solaris ld & gold would fail with:
Undefined first referenced
symbol in file
XShapeQueryExtension .libs/Command.o (symbol belongs to implicit dependency libXext.so.0)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
|
|
The %name-prefix "prefix" syntax was introduced in bison 2.3b and
is not supported in older bison and yacc parsers.
Without this fix, bison 2.3 (older than 2.3b) gives the cryptic error:
.../src/laygram.y:1.14-20: syntax error, unexpected string, expecting =
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Tested-by: Gaetan Nadon <memsize@videotron.ca>
|
|
rather than #include "TemplateP.h".
Acked-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Expections: TexTr.c, sharedlib.c ans generated lex and yacc C code.
XawI18n.h needs HAVE_WCTYPE_H and HAVE_WCHAR_H.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
Tested-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Matt Turner <mattst88@gmail.com>
|
|
AsciiSink.c:132:41: warning: initialization from incompatible pointer type
AsciiSink.c:135:41: warning: initialization from incompatible pointer type
AsciiSink.c:137:41: warning: initialization from incompatible pointer type
Vendor.c:199:24: warning: initialization from incompatible pointer type
Vendor.c:269:24: warning: initialization from incompatible pointer type
Vendor.c:284:24: warning: initialization from incompatible pointer type
Viewport.c:143:3: warning: initialization from incompatible pointer type
MultiSink.c:160:41: warning: initialization from incompatible pointer type
MultiSink.c:162:41: warning: initialization from incompatible pointer type
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Gaetan Nadon <memsize@videotron.ca>
Acked-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Gaetan Nadon <memsize@videotron.ca>
Acked-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Gaetan Nadon <memsize@videotron.ca>
Acked-by: Matt Turner <mattst88@gmail.com>
|
|
This is a requirement for all modules.
www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
All published Xaw3d header file are included this way.
The -I directive to include/X11/Xaw3d is removed which will alert
developers not to include header files with quotes unless they are in
the /src directory.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This will also prevent confusion as it is not obtained from PKG_CHECK_MODULES
but follows its naming convention.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
AM_CPPFLAGS should only contain preprocessor directives like -I -D.
The various *_CFLAGS may contain compiler flags as they are obtained
from pkg-config Cflags variable.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This configuration snippet is copied from app/twm and xgc.
It handles the case when yacc tool is missing but yacc generated code in the
tarball can be used.
Unlike other macros AC_PROG_YACC sets the YACC variable to "yacc"
as a last resort, even if no programs have been found.
Improve error checking by issuing an error message if yacc is not found.
The module cannot build anyway, unless from a published tarball.
If laygram.c is already there, do not abort the configuration
if yacc is missing as it is not needed.
If both generated code and yacc are missing, abort configuration.
Yacc is a required tool to build the package.
The test for YACC_INST is cross-compiling friendly.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Automake will handle the distribution of laygram.h
http://www.gnu.org/software/automake/manual/automake.html#Yacc-and-Lex
http://cgit.freedesktop.org/xorg/app/twm/tree/src/Makefile.am
http://cgit.freedesktop.org/xorg/app/xgc/tree/Makefile.am
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Acked-by: Gaetan Nadon <memsize@videotron.ca>
|