Age | Commit message (Collapse) | Author |
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Stop working around a bug in the macII A/UX 1.0 cc
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
It was only built by Imake if SUNSHLIB was defined.
SUNSHLIB was only set in the Imake configs for SunOS versions < 5
(i.e. before Solaris 2.0).
It has never been used in the autoconf builds.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
MultiSink.c: In function ‘SetValues’:
MultiSink.c:582:18: error: passing argument 1 of ‘SetTabs’ from
incompatible pointer type [-Werror=incompatible-pointer-types]
582 | SetTabs( w, w->text_sink.tab_count, w->text_sink.char_tabs );
| ^
| |
| MultiSinkObject {aka struct _MultiSinkRec *}
MultiSink.c:99:21: note: expected ‘Widget’ {aka ‘struct _WidgetRec *’}
but argument is of type ‘MultiSinkObject’ {aka ‘struct _MultiSinkRec *’}
99 | static void SetTabs(Widget, int, short *);
| ^~~~~~
Adopts change originally made to libXaw in XFree86 4
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Import wrapper function with expected arguments from libXaw,
where it appears to have been originally fixed in XFree86 3.9Nb
by Paulo Cesar Pereira de Andrade.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
|
|
When filling in the array, we correctly limited to the 256 slots allocated
but then we reset the value to an unlimited number when passing it on to
the function that walks the array, which could lead to it walking too far.
Fixes https://gitlab.freedesktop.org/xorg/lib/libxaw/issues/2
Reported-by: Praveen Kumar <praveen.pk@samsung.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
(Adapted from libXaw commit c01d47c4c0e0a66e0989d40f73827d0a55f693cc)
|
|
Reported by parfait 1.1 bug checking tool:
File Descriptor Leak: Leaked File Descriptor fd
at line 1098 of src/MultiSrc.c in function 'WriteToFile'.
fd initialized at line 1096 with creat
fd leaks when creat(name, 438) != -1 at line 1096.
(Adapted from libXaw commit a30892ed9b6d193f6eb2bab5b37180ac8f63b0b1.)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
http://bugs.freedesktop.org/show_bug.cgi?id=24635
(Adapted from libXaw commit f373e193a48eaf6d799d0b6ad32fd58d8ae8b3bd.)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Reported by: https://bugs.freedesktop.org/show_bug.cgi?id=94375
Fix copied from 2D libXaw commit 11c3a104141e1a4946ad949dfb5514df0b66a031
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
vendorShellWidgetClass
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
|
|
For long arguments, use labs().
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
No longer need #define to substitute it now that we no longer set
it to a different type on CRAY systems.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Makes code for _XawImCallVendorShellExtResize identical to libXaw.
Fixes
XawIm.c: In function '_XawImCallVendorShellExtResize':
XawIm.c:1554:2: warning: passing argument 1 of 'XawVendorShellExtResize' from incompatible pointer type [enabled by default]
XawIm.c:93:13: note: expected 'Widget' but argument is of type 'VendorShellWidget'
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Fix up from 5d367cd9d0c. No functional changes.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Same fix appeared in libXaw as part of XFree86 4.3.0.1.
Fixes: http://gnats.netbsd.org/37610
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Patch found at http://gitorious.org/xaw3d/xaw3d/commit/ccb1ffde090006f5a715c1e3d4da5f4d6fae05d3
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Found at http://gitorious.org/xaw3d/xaw3d/commit/3ba3e52454bb684a73601ec91e2c274e776f711a
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
This ugly piece of magic was copied from libXaw, and now scrollbars
will work slightly less incorrectly than they did before.
Found at http://gitorious.org/xaw3d/xaw3d/commit/4ec68aebffbdc406139f880f92b6c18b835af6d4
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Fixes segmentation fault when closing gv.
Found at http://gitorious.org/xaw3d/xaw3d/commit/23b3ca50395f180cba4a923eb8827dcc961629da
Fixes: https://bugs.gentoo.org/show_bug.cgi?id=406487
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Introduced in f6cd786d1.
Reported-by: Jean-Pierre Demailly <Jean-Pierre.Demailly@ujf-grenoble.fr>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
AsciiText.h doesn't include MultiSrc.h when internationalization is
disabled, so dcd27a9c69a was breaking the build. Also fix a typo
introduced in the same commit Xaw -> Xaw3d.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
When XAW_INTERNATIONALIZATION isn't defined, some uninitialized stack
data was being passed to XtGetValues. This makes it not do that.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46124
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Devin J. Pohly <djpohly+xorg@gmail.com>
|
|
Noticed when comparing with libXaw's AllWidgets.c.
|
|
Makes these two files closer to the libXaw originals.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Caught a mistake in SmeThreeD.h: smeThreeDWidgetClass was declared
instead of smeThreeDObjectClass.
Also fixes redundant redeclaration warnings.
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Box.c:265:10: warning: declaration shadows a local variable [-Wshadow]
int i = bbw->composite.num_children;
^
Box.c:166:15: note: previous declaration is here
Cardinal i;
^
1 warning generated.
Form.c:809:9: warning: declaration shadows a local variable [-Wshadow]
Widget w = *childP;
^
Form.c:793:24: note: previous declaration is here
XawFormDoLayout(Widget w,
^
1 warning generated.
Viewport.c:627:24: warning: declaration shadows a local variable [-Wshadow]
if (!needshoriz) CheckHoriz();
^
Viewport.c:605:14: note: expanded from macro 'CheckHoriz'
Widget bar = w->viewport.horiz_bar; \
^
Viewport.c:620:14: note: previous declaration is here
Widget bar = w->viewport.vert_bar;
^
1 warning generated.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Tip.c:336:9: error: implicit declaration of function 'abs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ksy += abs(ext->max_ink_extent.y);
^
1 error generated.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Was toupper() *really* expensive when this was written? :)
Also, initialize action_type with toupper(), since the check immediately
following assumes that its value is uppercase.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Fixes gcc warning:
Scrollbar.c: In function 'NotifyScroll':
Scrollbar.c:950:12: warning: 'call_data' may be used uninitialized in this function [-Wuninitialized]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warnings:
Scrollbar.c: In function 'NotifyScroll':
Scrollbar.c:955:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Text.c: In function 'HScroll':
Text.c:1274:41: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Text.c: In function 'VScroll':
Text.c:1431:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
TextPop.c: In function 'DoSearch':
TextPop.c:808:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
TextPop.c: In function 'Replace':
TextPop.c:942:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Viewport.c: In function 'ScrollUpDownProc':
Viewport.c:866:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warning:
Scrollbar.c: In function 'MoveThumb':
Scrollbar.c:1006:16: warning: variable 't' set but not used [-Wunused-but-set-variable]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warning:
laygram.c: In function 'LayYYparse':
laygram.y:242:7: warning: label 'unary' defined but not used [-Wunused-label]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Fixes gcc warnings:
laylex.c:1316:17: warning: 'yyunput' defined but not used [-Wunused-function]
laylex.c:1357:16: warning: 'input' defined but not used [-Wunused-function]
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|