diff options
| author | Jamey Sharp <jamey@minilop.net> | 2006-10-15 00:26:21 -0700 |
|---|---|---|
| committer | Jamey Sharp <jamey@minilop.net> | 2006-10-15 00:33:56 -0700 |
| commit | c27e00ceceed3fea011c98c0e70ab568bf0687c6 (patch) | |
| tree | 62871bc653a38f2477f8043e7b17e4657cb48436 /src/XSetDVal.c | |
| parent | 5dda1e1509d40ef64ebc816ce538cef462a4fa51 (diff) | |
Don't call XInput_find_display in _XiCheckExtInit, while the Display lock is held.
All callers of _XiCheckExtInit have already called XInput_find_display
first outside the lock, so just pass their copy of the XExtDisplayInfo
structure down. Besides being more correct, this should be slightly
faster. :-)
Thanks to Magnus Kessler <Magnus.Kessler@gmx.net> for identifying
the bug and proposing a workaround.
Diffstat (limited to 'src/XSetDVal.c')
| -rw-r--r-- | src/XSetDVal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/XSetDVal.c b/src/XSetDVal.c index 6b382f1..43702b0 100644 --- a/src/XSetDVal.c +++ b/src/XSetDVal.c @@ -74,7 +74,7 @@ XSetDeviceValuators(dpy, dev, valuators, first_valuator, num_valuators) XExtDisplayInfo *info = XInput_find_display(dpy); LockDisplay(dpy); - if (_XiCheckExtInit(dpy, XInput_Add_XSetDeviceValuators) == -1) + if (_XiCheckExtInit(dpy, XInput_Add_XSetDeviceValuators, info) == -1) return (NoSuchExtension); GetReq(SetDeviceValuators, req); |