summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-08-25XInput_find_display: Don't dereference NULL dpyinfoAlan Coopersmith
Unlikely, but could happen if calloc fails in XextAddDisplay() Relies on XextHasExtension(i) macro from <X11/extensions/extutil.h> which checks for ((i) && ((i)->codes)) Fixes: #15 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-23gitlab CI: enable gitlab's builtin static analysisAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-23gitlab CI: enable commit & merge request checksAlan Coopersmith
Uses ci-fairy from freedesktop/ci-templates Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-17Fix spelling/wording issuesAlan Coopersmith
Found by using: codespell --builtin clear,rare,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-17Build xz tarballs instead of bzip2Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-09-15libXi 1.8libXi-1.8Povilas Kanapickas
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2021-09-15Bump the requirement of inputproto to 2.3.99.1Povilas Kanapickas
2021-09-04man: Document XIAllowEventsPovilas Kanapickas
2021-06-01libXi 1.7.99.2libXi-1.7.99.2Povilas Kanapickas
2021-05-30gitlab-ci: Setup gitlab buildPovilas Kanapickas
2021-05-30Fix compile error that slipped throughPovilas Kanapickas
Lesson for the future: make sure the private environment (e.g convenience scripts) don't add changes where they are not expected. In my case I'm building and installing Debian packages straigth away. And one of the extra commits for Debian support had a change that had to go to the libXi repository. The development snapshot 1.7.99.1 has thus not been released (only a commit with the version bump was pushed). Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2021-05-30libXi 1.7.99.1Povilas Kanapickas
2020-10-10Update the list of supported XI versionsPovilas Kanapickas
2020-10-10Add support for XI 2.4 gesture eventsPovilas Kanapickas
2020-10-04man pages: fix more typosAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-10-04man pages: Add more missing spaces.Alan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-10-04man/XGrabDeviceButton.txt: Fix bad .P -> paragraph break conversionAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-10-04Fix typos in manual pagesSamanta Navarro
2019-06-19libXi 1.7.10libXi-1.7.10Matt Turner
Signed-off-by: Matt Turner <mattst88@gmail.com>
2019-06-19Replace open-coded FP3232_TO_DOUBLEMatt Turner
Signed-off-by: Matt Turner <mattst88@gmail.com>
2019-06-17Fix the FIXME in XIValuatorClass case of copy_classes function in XExtInt.cAlexander Bersenev
In addition fix FP3232_TO_DOUBLE macro to correctly compute the fractional part. This fixes glitchy scrolling in Qt applications when the application was just activated or was scrolled in the backgroud. Qt uses XIQueryDevice call to synchronize internal scroll location with an actual one. Bug: https://gitlab.freedesktop.org/xorg/lib/libxi/issues/10
2018-12-07Update configure.ac bug URL for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-19Update README for gitlab migrationAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-10-27Update XIChangeHierarchy.txtRaphaël Droz
2018-02-06_XIPassiveGrabDevice needs to set time valueJeff Smith
When setting up a XIPassiveGrabDevice request, the time field is not being set, leading to improper data being passed 'over the wire'. Accept a time value into _XIPassiveGrabDevice and use it to set the time field in the request. Since the the functions calling _XIPassiveGrabDevice are part of the API, and they do not accept time values, they can just pass CurrentTime. Signed-off-by: Jeff Smith <whydoubt@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-06-14man: add a bunch of missing spacesPeter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen: add default patch prefixMihail Konev
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2017-01-23libXi 1.7.9libXi-1.7.9Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-12-29Fix possible free of uninitialized pointerEmilio Pozuelo Monfort
If the _XReply() call fails, we'll try to free an uninitialized pointer. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849026 Reported-by: Thomas Walker <thwalker3@gmail.com> Signed-off-by: Emilio Pozuelo Monfort <pochu@debian.org> Reviewed-by: Julien Cristau <jcristau@debian.org> Tested-by: Thomas Walker <thwalker3@gmail.com> Signed-off-by: Julien Cristau <jcristau@debian.org>
2016-10-26Check that allocating a buffer succeededEmilio Pozuelo Monfort
Since we are going to write into the buffer, we should make sure the allocation didn't fail. Reported-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Emilio Pozuelo Monfort <pochu@debian.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-10-26Plug a memory leakEmilio Pozuelo Monfort
Introduced in commit 19a9cd6. Reported-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Emilio Pozuelo Monfort <pochu@debian.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-10-25libXi 1.7.8libXi-1.7.8Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2016-10-13XListInputDevices: don't touch ndevices in case of errorPeter Hutterer
We used to always set *ndevices to the number of devices returned by the server. This magically worked because we pretty much never returned an error except on faulty server or library implementations. With 19a9cd60 we now have more chances of getting an error, so the polite thing is to just leave *ndevices alone when we error out. Document it as such in the man page, just in case someone accidentally reads it. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> CC: Niels Ole Salscheider <niels_ole@salscheider-online.de> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
2016-10-13SizeClassInfo can return 0 even without an errorNiels Ole Salscheider
Catch the error case separately. Commit 19a9cd607d added length checking to SizeClassInfo but re-used the return value of 0 for an error. A device without classes (as is initialized by xf86-input-libinput for tablets) can legitimately return 0 and erroneously triggers an error. Fix this by using a separate value for the error. Reproducible by calling XListInputDevices() with a tablet attached. This fixes a regression introduced in commit 19a9cd607d. Signed-off-by: Niels Ole Salscheider <niels_ole@salscheider-online.de> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
2016-10-04libXi 1.7.7libXi-1.7.7Matthieu Herrb
Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
2016-09-25Properly validate server responses.Tobias Stoeckmann
By validating length fields from server responses, out of boundary accesses and endless loops can be mitigated. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
2015-12-22libXi 1.7.6libXi-1.7.6Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-11-03Fix const compiler warningsJavier Pello
When invoking Data, Data16 and Data32 from XChangeDeviceProperty, we must cast the data pointer to the right type, but we do not need to cast constness away. This change allows to enable -Wcast-qual on the build and have it complete without warnings. Signed-off-by: Javier Pello <javier.pello@urjc.es> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-10-19Don't use raw serial numbers in XIEventsPeter Hutterer
cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). This serial may be different to the raw serial number from the wire protocol. This causes issues when the raw serial is used to e.g. compare the event to other non-XI events. Use the cookie's serial number instead. https://bugzilla.gnome.org/show_bug.cgi?id=756649 See also https://bugs.freedesktop.org/show_bug.cgi?id=64687 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-09-10libXi 1.7.5libXi-1.7.5Peter Hutterer
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-02-24Fix version check in _XIAllowEventsCosimo Cecchi
Commit 5810d0797160a97012664ffe719a59e1b288a525 changed _XIAllowEvents() to use _XiCheckVersion() instead of _XiCheckExtInit() to avoid a double display unlock, but it failed to correctly check for the version, since we should set have_XI22 to True for every version greater or equal to 2.2. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-04XIGrabDevice: Unlock display in error path.Michal Srb
Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-03Refactor XGetExtensionVersion.Michal Srb
_XiGetExtensionVersion was called from XGetExtensionVersion and from _XiCheckExtInit. When called from _XiCheckExtInit, nothing accounted for the fact that it can return ((XExtensionVersion *) NoSuchExtension) in case of error. Also it recursively calls _XiCheckExtInit potentionally causing multiple unlocks if _XiCheckExtInit fails. -> Remove it and call directly _XiGetExtensionVersionRequest and only call _XiCheckExtInit only from XGetExtensionVersion. Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-03Fix logic in _XIAllowEvents and prevent double unlock.Michal Srb
Replacing the second _XiCheckExtInit with _XiCheckVersion prevents possible double unlock as _XiCheckExtInit actually unlocks the display when it returns -1. Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-03XIGetClientPointer: Return False on error.Michal Srb
Not NoSuchExtension which is 1 = True! Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-03Do not return NoSuchExtension casted to pointer as an error.Michal Srb
Several functions were returning NoSuchExtension casted to a pointer in case of an error. Often in parallel with returning NULL in case of another error. It is undocumented and certainly wrong. Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-03XIChangeHierarchy: Add missing unlock.Michal Srb
When num_changes <= 0 or Xmalloc fails, the display has to be unlocked. Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-11-03Fix double unlock when _XiCheckExtInit return -1.Michal Srb
_XiCheckExtInit unlocks the display if it fails and returns -1. Most callers account for it properly, but few didn't. Signed-off-by: Michal Srb <msrb@suse.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-28 11:16:59 +0000