| Age | Commit message (Collapse) | Author |
|---|
|
_XiCheckExtInit unlocks the display if it fails and returns -1. Most callers
account for it properly, but few didn't.
Signed-off-by: Michal Srb <msrb@suse.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
If the number of items reported by the server is large enough that
it overflows when multiplied by the size of the appropriate item type,
then memory corruption can occur when more bytes are copied from the
X server reply than the size of the buffer we allocated to hold them.
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
rep.length is a CARD32, so rep.length << 2 could overflow in 32-bit builds
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Each XI2 call should check _XiCheckExtInit for XI version 2.0 or higher.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
|
|
In error case length of extra data could be uninitialized. This would
result randomly sized request later in function.
Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
|
|
If a client issues an XI2 request against a non-XI2 server it should
generate a BadRequest error from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
XIGetProperty always returns in the specified format (8, 16, 32) and never in
the Xlib's 64-bit long hackery. So we can clean this code up a bit.
This doesn't affect XListProperties, it still returns an Atom list.
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
|
|
Without Xlib's 64-bit hilarity. A property claiming to be 32 bit is treated
as 32 bit value.
|
