summaryrefslogtreecommitdiff
path: root/src/XrrOutput.c
diff options
context:
space:
mode:
authorAlan Coopersmith <alan.coopersmith@oracle.com>2013-06-30 16:52:59 -0700
committerAlan Coopersmith <alan.coopersmith@oracle.com>2013-07-05 21:07:42 -0700
commit9e4abe746786f0f632d1f82f99fe0c6b8ffedf9e (patch)
tree1993634a1d6c6661e232a8f1f10ff0223f52bd11 /src/XrrOutput.c
parentf97d44f8fb9f90ce3227cca8affd3b947e9b08ca (diff)
XRRGetProviderInfo returned bad associated_capability list in 64-bit
Unlike most of the values returned by this function, which are arrays of XIDs (long int), associated_capability is defined as an array of unsigned int. _XRead32 reads 32-bit values from the wire protocol and writes them to the provided buffer as an array of long ints, even if that means expanding them from 32-bit to 64-bit. Doing that for associated_capability resulted in a garbage value between each actual value, and overflowing the provided buffer into the space for the provider name (which is written later and would overwrite the overflowed data). Created xhiv libXrandr/XRRGetProviderInfo test case to test & confirm. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'src/XrrOutput.c')
0 files changed, 0 insertions, 0 deletions