summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-06use "const void *" rather than "char *" for memcmp, etcThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-05-06fix 5 more simple gcc warningsThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-05-06fix gcc warnings when assigning into a bit-field by first masking the valueThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-05-05fixes for typos and formatting glitchesThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-05-05ignore the generated file used for version-numberThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-05-04Provide suseconds_t typedef on Win32Jon Turney
Fix compilation on Win32 after cf9e8c73, where timeval is not defined in terms of that type, but a plain long.
2019-05-04Fix WHITEFILL after const fixesJon Turney
Fix compilation of ExtractLocaleName() when WHITEFILL is defined (when built for Win32) after const fixes in ffeb733d.
2019-04-28improved markup for the restored pagesThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-28restore the last 3-4 pages of "Registering a New Resource Converter",Thomas E. Dickey
originally section 9.6.4 which lost in sgml/docbook conversion. Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-28Merge branch 'master' of ssh://gitlab.freedesktop.org/xorg/lib/libxtWalter Harms
2019-04-28Fix input starvation in XtMainLoop() closes bug #7Walter Harms
the function XtAppProcessEvent() can handle only one of XtIMXEvent | XtIMTimer | XtIMAlternateInput | XtIMSignal propperly. It returns after processing one type of input others are left unprocessed. putting enought input of one type, the later once will never processed.
2019-04-22Fix covscan complainBenjamin Tissoires
covscan gets confused by the test before the XtFree. Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/Event.c:743: alloc_fn: Storage is returned from allocation function "__XtMalloc". libXt-20190411/src/Event.c:743: var_assign: Assigning: "proc" = storage returned from "__XtMalloc((Cardinal)((size_t)numprocs * 16UL))". libXt-20190411/src/Event.c:745: var_assign: Assigning: "closure" = "proc". libXt-20190411/src/Event.c:776: leaked_storage: Variable "closure" going out of scope leaks the storage it points to. libXt-20190411/src/Event.c:776: leaked_storage: Variable "proc" going out of scope leaks the storage it points to. Mixing static arrays and dynamic ones was a good idea in the 90s when malloc was expensive, but now, we should probably make the code clearer by just allocating the memory when needed. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
2019-04-22dummy fix for covscanBenjamin Tissoires
covscan seems lost here: Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/Intrinsic.c:1074: alloc_fn: Storage is returned from allocation function "__XtMalloc". libXt-20190411/src/Intrinsic.c:1074: var_assign: Assigning: "buf2" = storage returned from "__XtMalloc(4096U)". libXt-20190411/src/Intrinsic.c:1110: leaked_storage: Variable "buf2" going out of scope leaks the storage it points to. Error: USE_AFTER_FREE (CWE-416): libXt-20190411/src/Intrinsic.c:1113: alias: Assigning: "buf" = "buf2". Now both point to the same storage. libXt-20190411/src/Intrinsic.c:1108: freed_arg: "XtFree" frees "buf2". libXt-20190411/src/Intrinsic.c:1110: use_after_free: Using freed pointer "buf". Both are false positive, but we can make it understand where it is wrong. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
2019-04-22Fix leaks detected by covscanBenjamin Tissoires
The following leaks are reported by covscan: Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/ResConfig.c:542: alloc_arg: "_get_part" allocates memory that is stored into "part". libXt-20190411/src/ResConfig.c:544: noescape: Resource "part" is not freed or pointed-to in "_match_resource_to_widget". libXt-20190411/src/ResConfig.c:560: leaked_storage: Variable "part" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/TMgrab.c:108: alloc_arg: "XtKeysymToKeycodeList" allocates memory that is stored into "keycodes". libXt-20190411/src/TMgrab.c:115: var_assign: Assigning: "keycodeP" = "keycodes". libXt-20190411/src/TMgrab.c:124: leaked_storage: Variable "keycodeP" going out of scope leaks the storage it points to. libXt-20190411/src/TMgrab.c:124: leaked_storage: Variable "keycodes" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/TMparse.c:1544: alloc_fn: Storage is returned from allocation function "XtMalloc". libXt-20190411/src/TMparse.c:1544: var_assign: Assigning: "event" = storage returned from "XtMalloc(88U)". libXt-20190411/src/TMparse.c:1549: noescape: Resource "event" is not freed or pointed-to in "ParseQuotedStringEvent". libXt-20190411/src/TMparse.c:1555: leaked_storage: Variable "event" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/TMparse.c:1779: alloc_fn: Storage is returned from allocation function "XtMalloc". libXt-20190411/src/TMparse.c:1779: var_assign: Assigning: "action" = storage returned from "XtMalloc(32U)". libXt-20190411/src/TMparse.c:1784: noescape: Resource "action" is not freed or pointed-to in "ParseAction". libXt-20190411/src/TMparse.c:1785: leaked_storage: Variable "action" going out of scope leaks the storage it points to. In addition to this legitimate leaks, covscan can get confused by the allocated memory in XtKeysymToKeycodeList: Error: RESOURCE_LEAK (CWE-772): libXt-20190411/src/TMgrab.c:108: alloc_arg: "XtKeysymToKeycodeList" allocates memory that is stored into "keycodes". libXt-20190411/src/TMgrab.c:114: leaked_storage: Variable "keycodes" going out of scope leaks the storage it points to. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
2019-04-21adapt change from libXaw for inserting the package version into the specThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21bump to 1.1.5.1 (actually 1.2.0 should be the target)Thomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21updated the acknowledgements section, and added a few notes to the release-7 ↵Thomas E. Dickey
section Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21summarize the const-changes in X11R7+Thomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21add #include for <X11/Intrinsic.h> to manpages, per conventionThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21move MenuPopdown and MenuPopup to section to distinguish these actions from ↵Thomas E. Dickey
C prototypes (and use the "Xt" prefix for these names as implemented since X11R4). Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21minor tweak to work around docbook's limited formattingThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21fill in a few missing typedef keywords, and a missing "*" in prototype, as ↵Thomas E. Dickey
well as minor clarification of "XtIs<class>" Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21add some missing "typedef" keywords for prototyped function-pointers.Thomas E. Dickey
also, use "type" markup in some of the places where it's needed. Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21fill in prototype information for a code example, as well as forThomas E. Dickey
the XtRFunction resource type. Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21fill in background for wide-prototypesThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21begin section on the conversion to standard CThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-21finish summarizing X11R6 vs documentation updatesThomas E. Dickey
2019-04-21summarize X11R6.3 and X11R6.4 changesThomas E. Dickey
2019-04-21The interface changes made recently have to be documented, and due to theThomas E. Dickey
time interval, etc., in turn requires an update to the specification version. Update that now.
2019-04-21update xorg's documentation-urlsThomas E. Dickey
2019-04-17fix cut/paste error in description of --enable-geo-tattler configure optionThomas E. Dickey
(reported by Alan Coopersmith) Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16remove calls to "IN" macro, which was recently removed from headerThomas E. Dickey
2019-04-16Add --disable-const and --enable-geo-tattler options for new/updated features.Thomas E. Dickey
Also, show configure choices for build-logs. Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16update manpage prototype for XtFindFile()Thomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net> Conflicts: man/XtFindFile.man
2019-04-16use ldquo/rdquo/ndash where appropriateThomas E. Dickey
2019-04-16correct an error from the original document's depiction of escape_charThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16use ldquo/rdquo/ndash where appropriateThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16trim spurious backslashes from translation of nroff to docbook xmlThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16The conversion to xml overlooked the nroff document's use of "\%" forThomas E. Dickey
hyphenation (remove those). Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16use lineannotation tagThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16whitespace/formatting fixThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16use lineannotation tagThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16whitespace/formatting fixesThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16formatted sample code to fit in 80 columnsThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16use lineannotation tag to solve font mismatches for xref's insideThomas E. Dickey
programlisting Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16use consistent labeling for xref'sThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16use programlisting tag rather than workaround for literallayout font.Thomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16fill in titles for some references to ICCCM and X11 documentsThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16fix ``fake quotes''Thomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
2019-04-16corrected some nested list formattingThomas E. Dickey
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>