From b1eaa18835ec7c3a11e580340625b35c18edf7ca Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Wed, 2 Feb 2011 23:21:02 -0800 Subject: GetResources: protect against underflow when type conversion fails Fix originally created by Leo Binchy for Sun to fix Solaris bug 1211553: XtVaCreateManagedWidget with list of resources XtVaTypedArg cause core dump Signed-off-by: Alan Coopersmith --- src/Resources.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/Resources.c b/src/Resources.c index 304d3d5..dc0f563 100644 --- a/src/Resources.c +++ b/src/Resources.c @@ -857,7 +857,7 @@ static XtCacheRef *GetResources( register XtTypedArg* arg = typed_args + typed[j] - 1; register int i; - for (i = num_typed_args - typed[j]; i; i--, arg++) { + for (i = num_typed_args - typed[j]; i > 0; i--, arg++) { *arg = *(arg+1); } num_typed_args--; -- cgit v1.2.3