From 478d4e5873eeee2ebdce6673e4e3469816ab63b8 Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Sat, 13 Apr 2013 00:50:02 -0700 Subject: integer overflow in XvMCListSubpictureTypes() [CVE-2013-1990 2/2] rep.num is a CARD32 and needs to be bounds checked before multiplying by sizeof(XvImageFormatValues) to come up with the total size to allocate, to avoid integer overflow leading to underallocation and writing data from the network past the end of the allocated buffer. Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith --- src/XvMC.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/XvMC.c b/src/XvMC.c index 5d8c2cf..8d602ec 100644 --- a/src/XvMC.c +++ b/src/XvMC.c @@ -184,8 +184,8 @@ XvImageFormatValues * XvMCListSubpictureTypes ( } if(rep.num > 0) { - ret = - (XvImageFormatValues*)Xmalloc(rep.num * sizeof(XvImageFormatValues)); + if (rep.num < (INT_MAX / sizeof(XvImageFormatValues))) + ret = Xmalloc(rep.num * sizeof(XvImageFormatValues)); if(ret) { xvImageFormatInfo Info; -- cgit v1.2.3