diff options
| author | Emil Velikov <emil.l.velikov@gmail.com> | 2014-09-05 01:46:40 +0100 |
|---|---|---|
| committer | Uli Schlachter <psychon@znc.in> | 2014-10-03 23:53:54 +0200 |
| commit | 382d306d6c44a9ece5551c210a932773b5cb94a5 (patch) | |
| tree | c62697721384c02e88835d8fb6c72be67dc80433 /check-pc-requires | |
| parent | b0e6c2de09c7474868dd7185674fa113a5c2e0aa (diff) | |
Move internal/private dependencies to Requires.private
Program using the xcb sub-modules has indirect compile and runtime
dependency of core xcb. To ensure this out we currently list xcb in
the Requires field of the pkg-config files. While this provides all
the required dependencies for successful compilation this causes
over-linking and hides potential linking miss-use against the xcb modules.
By moving to Requires.private we retain the compilation and runtime
compatibility and avoids any runtime problems.
Cc: Keith Packard <keithp@keithp.com>
Cc: Alan Coopersmith <alan.coopersmith@oracle.com>
References: http://people.freedesktop.org/~dbn/pkg-config-guide.html#faq
References: https://wiki.mageia.org/en/Overlinking_issues_in_packaging
References: http://err.no/personal/blog/2008/Mar/25
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Signed-off-by: Uli Schlachter <psychon@znc.in>
Diffstat (limited to 'check-pc-requires')
| -rwxr-xr-x | check-pc-requires | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/check-pc-requires b/check-pc-requires index 0fd9c65..063356f 100755 --- a/check-pc-requires +++ b/check-pc-requires @@ -23,7 +23,7 @@ for inc in src/*.h; do included=`grep '# *include' $inc | sed -e 's/[^<"]*[<"]//' -e 's/[>"]//' | grep -v 'xcb.h\|xproto.h'` - requires=`grep '^Requires:' $pcin` + requires=`grep '^Requires.private:' $pcin` missing="" for i in $included; do ibase=`basename $i .h` @@ -58,7 +58,7 @@ for inc in src/*.h; do *) if [ "$fix" = "y" ]; then echo $package adding dependency on $missing - sed -i '/^Requires:/s/$/ '"$missing"'/' $pcin + sed -i '/^Requires.private:/s/$/ '"$missing"'/' $pcin else echo $package missing $missing status=1 |