summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTheo de Raadt <deraadt@cvs.openbsd.org>2019-06-28 13:47:34 +0000
committerTheo de Raadt <deraadt@cvs.openbsd.org>2019-06-28 13:47:34 +0000
commit11a95e36dd26166202bcffe1fb7e3b8a72509d9e (patch)
tree5da721c66155fcc419e717a098a8ccb83f565525
parent82f05f7038fa65ca0f20878b116938633dcc582b (diff)
When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
-rw-r--r--libexec/tradcpp/files.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libexec/tradcpp/files.c b/libexec/tradcpp/files.c
index e59388f0abb..d49f56640a0 100644
--- a/libexec/tradcpp/files.c
+++ b/libexec/tradcpp/files.c
@@ -336,7 +336,7 @@ file_tryopen(const char *file)
/* XXX check for non-regular files */
fd = open(file, O_RDONLY);
- if (fd < 0) {
+ if (fd == -1) {
if (errno != ENOENT && errno != ENOTDIR) {
complain(NULL, "%s: %s", file, strerror(errno));
}