summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTheo de Raadt <deraadt@cvs.openbsd.org>1998-06-29 22:43:59 +0000
committerTheo de Raadt <deraadt@cvs.openbsd.org>1998-06-29 22:43:59 +0000
commit82ad04a68e7506e16becc2090fd0fb4d42a927bd (patch)
tree08811562110f472dab4ee9a1069464fa2d572abd
parenta0dcbd64f6e48a7e41afc3f164499d7c14145de9 (diff)
do not (void)kvm_read(...)
-rw-r--r--sbin/savecore/savecore.c16
1 files changed, 11 insertions, 5 deletions
diff --git a/sbin/savecore/savecore.c b/sbin/savecore/savecore.c
index deca460a821..f5f9fa1ce1b 100644
--- a/sbin/savecore/savecore.c
+++ b/sbin/savecore/savecore.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: savecore.c,v 1.9 1998/03/25 23:38:52 deraadt Exp $ */
+/* $OpenBSD: savecore.c,v 1.10 1998/06/29 22:43:58 deraadt Exp $ */
/* $NetBSD: savecore.c,v 1.26 1996/03/18 21:16:05 leo Exp $ */
/*-
@@ -251,8 +251,11 @@ kmem_setup()
KREAD(kd_kern, current_nl[X_DUMPMAG].n_value, &dumpmag);
if (kernel == NULL) {
- (void)kvm_read(kd_kern, current_nl[X_VERSION].n_value,
- vers, sizeof(vers));
+ if (kvm_read(kd_kern, current_nl[X_VERSION].n_value,
+ vers, sizeof(vers)) == -1) {
+ syslog(LOG_ERR, "%s: kvm_read: version misread", dump_sys);
+ exit(1);
+ }
vers[sizeof(vers) - 1] = '\0';
}
@@ -294,8 +297,11 @@ check_kmem()
register int panicloc;
char core_vers[1024];
- (void)kvm_read(kd_dump, dump_nl[X_VERSION].n_value, core_vers,
- sizeof(core_vers));
+ if (kvm_read(kd_dump, dump_nl[X_VERSION].n_value, core_vers,
+ sizeof(core_vers) != sizeof(core_vers))
+ syslog(LOG_ERR, "%s: kvm_read: version misread", dump_sys);
+ exit(1);
+ }
core_vers[sizeof(core_vers) - 1] = '\0';
if (strcmp(vers, core_vers) && kernel == 0)