diff options
| author | Jonathan Gray <jsg@cvs.openbsd.org> | 2010-04-20 06:59:48 +0000 |
|---|---|---|
| committer | Jonathan Gray <jsg@cvs.openbsd.org> | 2010-04-20 06:59:48 +0000 |
| commit | 8814798b2b3145aada3cdac1ddc61ee6d438358d (patch) | |
| tree | 8623a9d3d860ad5176bc5e7bd122d19227885d84 | |
| parent | 96eff2681adf0214d5de6ad9f25bfe184755b914 (diff) | |
Don't write garbage to the config space for phison,
we shouldn't be touching the config space at all here.
Found by the clang static analyser.
ok deraadt
| -rw-r--r-- | sys/dev/pci/pciide.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/sys/dev/pci/pciide.c b/sys/dev/pci/pciide.c index 0002f515519..cdd8551ac80 100644 --- a/sys/dev/pci/pciide.c +++ b/sys/dev/pci/pciide.c @@ -1,4 +1,4 @@ -/* $OpenBSD: pciide.c,v 1.307 2010/04/11 16:58:06 kettenis Exp $ */ +/* $OpenBSD: pciide.c,v 1.308 2010/04/20 06:59:47 jsg Exp $ */ /* $NetBSD: pciide.c,v 1.127 2001/08/03 01:31:08 tsutsui Exp $ */ /* @@ -8655,7 +8655,6 @@ phison_chip_map(struct pciide_softc *sc, struct pci_attach_args *pa) int channel; pcireg_t interface = PCI_INTERFACE(pa->pa_class); bus_size_t cmdsize, ctlsize; - u_int32_t conf; sc->chip_unmap = default_chip_unmap; @@ -8696,9 +8695,6 @@ phison_chip_map(struct pciide_softc *sc, struct pci_attach_args *pa) sc->sc_wdcdev.set_modes(&cp->wdc_channel); } - WDCDEBUG_PRINT(("%s: new conf register 0x%x\n", - sc->sc_wdcdev.sc_dev.dv_xname, conf), DEBUG_PROBE); - pci_conf_write(sc->sc_pc, sc->sc_tag, NFORCE_CONF, conf); } void |