summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTheo de Raadt <deraadt@cvs.openbsd.org>1996-01-05 13:35:29 +0000
committerTheo de Raadt <deraadt@cvs.openbsd.org>1996-01-05 13:35:29 +0000
commit65a703de9cedcd4f2575053d83355135b58b87b4 (patch)
tree23cb7cdceab46f6b92fce1f22f8c02fb390646ec
parent59d6e38756bfc586ea1b90415c612c3ae37aba86 (diff)
from netbsd:
XXX TEMPORARY STOP-GAP MEASURE! A 12-bit command modifier was being squished into an 8-bit position in a command stream! Which one is wrong? Changed the constant from 0x140 to 0x40, which is what ended up happening anyhow. This exists in the old Utah sources, too! How long has this bug existed?!
-rw-r--r--sys/arch/hp300/dev/ctreg.h9
-rw-r--r--sys/arch/hp300/dev/rdreg.h9
2 files changed, 16 insertions, 2 deletions
diff --git a/sys/arch/hp300/dev/ctreg.h b/sys/arch/hp300/dev/ctreg.h
index 15501f1b2b1..a95d9fabc26 100644
--- a/sys/arch/hp300/dev/ctreg.h
+++ b/sys/arch/hp300/dev/ctreg.h
@@ -1,4 +1,4 @@
-/* $NetBSD: ctreg.h,v 1.4 1994/10/26 07:23:29 cgd Exp $ */
+/* $NetBSD: ctreg.h,v 1.5 1995/12/31 04:11:42 thorpej Exp $ */
/*
* Copyright (c) 1982, 1990, 1993
@@ -165,7 +165,14 @@ struct ct_describe {
#define C_SSM 0x3e
#define C_WFM 0x49
#define C_UNLOAD 0x4a
+/*
+ * XXX XXX XXX THIS IS SUPPOSED TO FIT IN A 1-BYTE SPACE?!
+ */
+#if 0
#define C_REL 0x140
+#else
+#define C_REL 0x40 /* what ended up happening */
+#endif
#define C_CMD 0x05
#define C_EXEC 0x0e
diff --git a/sys/arch/hp300/dev/rdreg.h b/sys/arch/hp300/dev/rdreg.h
index 174afbcf432..9057532a7b1 100644
--- a/sys/arch/hp300/dev/rdreg.h
+++ b/sys/arch/hp300/dev/rdreg.h
@@ -1,4 +1,4 @@
-/* $NetBSD: rdreg.h,v 1.5 1994/10/26 07:24:54 cgd Exp $ */
+/* $NetBSD: rdreg.h,v 1.6 1995/12/31 04:11:43 thorpej Exp $ */
/*
* Copyright (c) 1988 University of Utah.
@@ -270,7 +270,14 @@ struct rd_describe {
#define C_SREL 0x3b
#define C_SSM 0x3e
#define C_SRAM 0x48
+/*
+ * XXX XXX XXX THIS IS SUPPOSED TO FIT IN A 1-BYTE SPACE?!
+ */
+#if 0
#define C_REL 0x140
+#else
+#define C_REL 0x40 /* what ended up happening */
+#endif
#define C_CMD 0x05
#define C_EXEC 0x0e