Don't leak a file descriptor when testing for permissions, also make

sure directory is executable, otherwise we can't list it.

Found by and original diff from RustyBSD.

While here, strlen returns a size_t not an int.

ok florian.

1 files changed, 4 insertions, 3 deletions

diff --git a/usr.bin/mg/dired.c b/usr.bin/mg/dired.c
index 184c9f7de4b..8630f2ec49d 100644
--- a/usr.bin/mg/dired.c
+++ b/usr.bin/mg/dired.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: dired.c,v 1.51 2012/03/14 13:56:35 lum Exp $	*/
+/*	$OpenBSD: dired.c,v 1.52 2012/11/03 15:36:03 haesbaert Exp $	*/
 
 /* This file is in the public domain. */
 
@@ -724,9 +724,10 @@ struct buffer *
 dired_(char *dname)
 {
 	struct buffer	*bp;
-	int		 len, i;
+	int		 i;
+	size_t		 len;
 
-	if ((fopen(dname,"r")) == NULL) {
+	if ((access(dname, R_OK | X_OK)) == -1) {
 		if (errno == EACCES)
 			ewprintf("Permission denied");
 		return (NULL);