diff options
| author | Charles Longeau <chl@cvs.openbsd.org> | 2008-09-01 19:18:31 +0000 |
|---|---|---|
| committer | Charles Longeau <chl@cvs.openbsd.org> | 2008-09-01 19:18:31 +0000 |
| commit | db519658f71331d60102964615a8e5b1612102b8 (patch) | |
| tree | 3944eff3bbe4af468cb778a4c01d84bf091172c2 | |
| parent | a599c8d122cabfcd439ac6424a67f197c8178e7e (diff) | |
avoid loosing return value from copyin, and properly return it.
initial patch from me, reworked by oga@.
found by LLVM/Clang Static Analyzer.
ok oga@
| -rw-r--r-- | sys/dev/pci/drm/drm_drawable.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/pci/drm/drm_drawable.c b/sys/dev/pci/drm/drm_drawable.c index be4444bda42..4d6e1929a90 100644 --- a/sys/dev/pci/drm/drm_drawable.c +++ b/sys/dev/pci/drm/drm_drawable.c @@ -171,7 +171,7 @@ drm_update_draw(struct drm_device *dev, void *data, struct drm_file *file_priv) /* For some reason the pointer arg is unsigned long long. */ ret = copyin((void *)(intptr_t)update->data, info->rects, sizeof(*info->rects) * info->num_rects); - DRM_SPINUNLOCK(&dev->drw_lock); + break; default: ret = EINVAL; } |