diff options
author | Joel Sing <jsing@cvs.openbsd.org> | 2016-11-03 08:15:23 +0000 |
---|---|---|
committer | Joel Sing <jsing@cvs.openbsd.org> | 2016-11-03 08:15:23 +0000 |
commit | 47e256e6d0b3a0445eba8acf3db8fdd6de888542 (patch) | |
tree | 1300aac8bddad91ea9ba38d6bbba2c1cc7bc7e09 /gnu | |
parent | e4328e180221223078acf187c34f15f30fd5152f (diff) |
Clean up the TLS handshake digest handling - this refactors some of the
code for improved readability, however it also address two issues.
The first of these is a hard-to-hit double free that will occur if
EVP_DigestInit_ex() fails. To avoid this and to be more robust, ensure
that tls1_digest_cached_records() either completes successfully and sets
up all of the necessary digests, or it cleans up and frees everything
that was allocated.
The second issue is that EVP_DigestUpdate() can fail - detect and handle
this in tls1_finish_mac() and change the return type to an int so that a
failure can be propagated to the caller (the callers still need to be
fixed to handle this, in a later diff).
The double-free was reported by Matthew Dillon.
ok beck@ doug@ miod@
Diffstat (limited to 'gnu')
0 files changed, 0 insertions, 0 deletions