summaryrefslogtreecommitdiff
path: root/lib/libc/gen/seekdir.c
diff options
context:
space:
mode:
authorKurt Miller <kurt@cvs.openbsd.org>2007-06-05 18:11:50 +0000
committerKurt Miller <kurt@cvs.openbsd.org>2007-06-05 18:11:50 +0000
commit5ea227edb4b41ecee104b943846b3df89ceafb8c (patch)
tree5e3932033b9b169395a0474156a37318fa74db42 /lib/libc/gen/seekdir.c
parent5727900f0e332290d68166eab7d4e4d71eea2264 (diff)
_FD_LOCK/UNLOCK() is libpthread specific and not needed for librthread, so
isolate its usage to libpthread only and replace with generic non-static mutex support in the one place it is needed: - remove _FD_LOCK/UNLOCK from lseek and ftruncate in libc and make the functions weak so that libpthread can override with its own new versions that do the locking. - remove _thread_fd_lock/unlock() weak functions from libc and adjust libpthread for the change. - add generic _thread_mutex_lock/unlock/destroy() weak functions in libc to support non-static mutexes in libc and add libpthread and librthread implementations for them. libc can utilize non-static mutexes via the new _MUTEX_LOCK/UNLOCK/DESTROY() macros. Actually these new macros can support both static and non-static mutexes but currently only using them for non-static. - make opendir/closedir/readdir/readdir_r/seekdir/telldir() thread-safe for both thread libraries by using a non-static mutex in the struct _dirdesc (typedef DIR), utilizing it in the *dir functions and remove remaining and incorrect _FD_LOCK/UNLOCK() use in libc. - add comments to both thread libraries to indicate libc depends on the current implementation of static mutex initialization. suggested by marc@ - major bump libc and libpthread due to function removal, structure change and weak symbol conversions. okay marc@, tedu@
Diffstat (limited to 'lib/libc/gen/seekdir.c')
-rw-r--r--lib/libc/gen/seekdir.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/libc/gen/seekdir.c b/lib/libc/gen/seekdir.c
index e472f62b789..2affbdd1ef1 100644
--- a/lib/libc/gen/seekdir.c
+++ b/lib/libc/gen/seekdir.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: seekdir.c,v 1.8 2006/04/01 18:06:59 otto Exp $ */
+/* $OpenBSD: seekdir.c,v 1.9 2007/06/05 18:11:48 kurt Exp $ */
/*
* Copyright (c) 1983, 1993
* The Regents of the University of California. All rights reserved.
@@ -30,6 +30,7 @@
#include <sys/param.h>
#include <dirent.h>
+#include "thread_private.h"
#include "telldir.h"
/*
@@ -39,6 +40,7 @@
void
seekdir(DIR *dirp, long loc)
{
-
+ _MUTEX_LOCK(&dirp->dd_lock);
__seekdir(dirp, loc);
+ _MUTEX_UNLOCK(&dirp->dd_lock);
}