signal handling changes. This corrects several signal

handling errors in the threads library.   Most of the libc_r regression
tests are now ok.   thread specific kill semantics are still not correct.
No negative comments after posting to tech@ a week or so ago.
siginfo test fails on sparc64 due to sparc64 oddity.

1 files changed, 8 insertions, 5 deletions

diff --git a/lib/libc_r/uthread/uthread_kill.c b/lib/libc_r/uthread/uthread_kill.c
index 172d3817513..59d78b80ebf 100644
--- a/lib/libc_r/uthread/uthread_kill.c
+++ b/lib/libc_r/uthread/uthread_kill.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: uthread_kill.c,v 1.7 1999/11/25 07:01:37 d Exp $	*/
+/*	$OpenBSD: uthread_kill.c,v 1.8 2002/10/30 19:11:56 marc Exp $	*/
 /*
  * Copyright (c) 1997 John Birrell <jb@cimlogic.com.au>.
  * All rights reserved.
@@ -38,6 +38,12 @@
 #include <pthread.h>
 #include "pthread_private.h"
 
+/*
+ * XXX THIS IS WRONG! The signal has to either come through the OS to
+ * get the proper siginfo, context, etc., or we need to gen up a
+ * siginfo (assuming needed).   Signal reset and other semantics
+ * also need to be obeyed.
+ */
 int
 pthread_kill(pthread_t pthread, int sig)
 {
@@ -75,7 +81,6 @@ pthread_kill(pthread_t pthread, int sig)
 				/* Return the signal number: */
 				pthread->signo = sig;
 			}
-			/* Increment the pending signal count: */
 			sigaddset(&pthread->sigpend,sig);
 			break;
 
@@ -88,7 +93,6 @@ pthread_kill(pthread_t pthread, int sig)
 				/* Return the signal number: */
 				pthread->signo = sig;
 			} else
-				/* Increment the pending signal count. */
 				sigaddset(&pthread->sigpend,sig);
 			break;
 
@@ -111,7 +115,6 @@ pthread_kill(pthread_t pthread, int sig)
 				/* Return the signal number: */
 				pthread->signo = sig;
 			} else {
-				/* Increment the pending signal count: */
 				sigaddset(&pthread->sigpend,sig);
 			}
 			break;
@@ -144,7 +147,7 @@ pthread_kill(pthread_t pthread, int sig)
 
 			/*
 			 * Dispatch the signal via the custom signal
-			 * handler:
+			 * handler: ;;; what about SA_SIGINFO???
 			 */
 			(*(_thread_sigact[sig - 1].sa_handler))(sig);