summaryrefslogtreecommitdiff
path: root/sbin/newfs_ext2fs
diff options
context:
space:
mode:
authorScott Soule Cheloha <cheloha@cvs.openbsd.org>2022-12-04 23:50:52 +0000
committerScott Soule Cheloha <cheloha@cvs.openbsd.org>2022-12-04 23:50:52 +0000
commit7119931719c16b3e14f3ca5213b351e777080528 (patch)
treedb01a02e50effc999803525fd4173a9bc9a2646f /sbin/newfs_ext2fs
parent45b7e652cd98369e756e28db16f4aad0626aec0d (diff)
userspace: remove vestigial '?' cases from top-level getopt(3) loops
getopt(3) returns '?' when it encounters a flag not present in the in the optstring or if a flag is missing its option argument. We can handle this case with the "default" failure case with no loss of legibility. Hence, remove all the redundant "case '?':" lines. Prompted by dlg@. With help from dlg@ and millert@. Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2 ok naddy@ millert@ dlg@
Diffstat (limited to 'sbin/newfs_ext2fs')
-rw-r--r--sbin/newfs_ext2fs/newfs_ext2fs.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sbin/newfs_ext2fs/newfs_ext2fs.c b/sbin/newfs_ext2fs/newfs_ext2fs.c
index 3017ec220cc..f7e48286f7c 100644
--- a/sbin/newfs_ext2fs/newfs_ext2fs.c
+++ b/sbin/newfs_ext2fs/newfs_ext2fs.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: newfs_ext2fs.c,v 1.28 2021/06/26 15:42:58 deraadt Exp $ */
+/* $OpenBSD: newfs_ext2fs.c,v 1.29 2022/12/04 23:50:47 cheloha Exp $ */
/* $NetBSD: newfs_ext2fs.c,v 1.8 2009/03/02 10:38:13 tsutsui Exp $ */
/*
@@ -212,7 +212,6 @@ main(int argc, char *argv[])
errx(EXIT_FAILURE,
"Volume name cannot be zero length");
break;
- case '?':
default:
usage();
}