diff options
| author | Artur Grabowski <art@cvs.openbsd.org> | 2007-04-13 18:57:50 +0000 |
|---|---|---|
| committer | Artur Grabowski <art@cvs.openbsd.org> | 2007-04-13 18:57:50 +0000 |
| commit | 8dcbe71580f80a022d075e6454486bc9d964c765 (patch) | |
| tree | a758a75bd2f6e39d8ea45545b501abbee0430ef1 /sys/arch/amd64 | |
| parent | 977eb8538189c8e232f80c85b5a0416ec6cd3670 (diff) | |
While splitting flags and pqflags might have been a good idea in theory
to separate locking, on most modern machines this is not enough
since operations on short types touch other short types that share the
same word in memory.
Merge pg_flags and pqflags again and now use atomic operations to change
the flags. Also bump wire_count to an int and pg_version might go
int as well, just for alignment.
tested by many, many. ok miod@
Diffstat (limited to 'sys/arch/amd64')
| -rw-r--r-- | sys/arch/amd64/amd64/pmap.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/arch/amd64/amd64/pmap.c b/sys/arch/amd64/amd64/pmap.c index ad4f9fc33cd..dfc1dcdb089 100644 --- a/sys/arch/amd64/amd64/pmap.c +++ b/sys/arch/amd64/amd64/pmap.c @@ -1,4 +1,4 @@ -/* $OpenBSD: pmap.c,v 1.19 2007/04/13 10:36:00 miod Exp $ */ +/* $OpenBSD: pmap.c,v 1.20 2007/04/13 18:57:49 art Exp $ */ /* $NetBSD: pmap.c,v 1.3 2003/05/08 18:13:13 thorpej Exp $ */ /* @@ -1169,7 +1169,7 @@ pmap_get_ptp(struct pmap *pmap, vaddr_t va, pd_entry_t **pdes) if (ptp == NULL) return NULL; - ptp->pg_flags &= ~PG_BUSY; /* never busy */ + atomic_clearbits_int(&ptp->pg_flags, PG_BUSY); ptp->wire_count = 1; pmap->pm_ptphint[i - 2] = ptp; pa = VM_PAGE_TO_PHYS(ptp); @@ -2593,7 +2593,7 @@ pmap_get_physpage(vaddr_t va, int level, paddr_t *paddrp) UVM_PGA_USERESERVE|UVM_PGA_ZERO); if (ptp == NULL) panic("pmap_get_physpage: out of memory"); - ptp->pg_flags &= ~PG_BUSY; + atomic_clearbits_int(&ptp->pg_flags, PG_BUSY); ptp->wire_count = 1; *paddrp = VM_PAGE_TO_PHYS(ptp); } |