diff options
| author | Kenneth R Westerback <krw@cvs.openbsd.org> | 2010-05-20 00:55:19 +0000 |
|---|---|---|
| committer | Kenneth R Westerback <krw@cvs.openbsd.org> | 2010-05-20 00:55:19 +0000 |
| commit | c713a7721e58dd0a453fae998afd21f12fd821e8 (patch) | |
| tree | 4c794ea604130c88f12d5a7295bcd0cb4624515f /sys/dev/i2o | |
| parent | 3c3718e53ebd6b33568092f43f11f6f1d0c4130e (diff) | |
New scsi code seems to be stable. Pluck previously identified
low-hanging splbio/splx pairs that are no longer needed and see if
this reveals any hidden scsi flaws.
ok dlg@
Diffstat (limited to 'sys/dev/i2o')
| -rw-r--r-- | sys/dev/i2o/iopsp.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/sys/dev/i2o/iopsp.c b/sys/dev/i2o/iopsp.c index 18388d9ce77..2572fcfd808 100644 --- a/sys/dev/i2o/iopsp.c +++ b/sys/dev/i2o/iopsp.c @@ -1,4 +1,4 @@ -/* $OpenBSD: iopsp.c,v 1.16 2010/03/23 01:57:19 krw Exp $ */ +/* $OpenBSD: iopsp.c,v 1.17 2010/05/20 00:55:17 krw Exp $ */ /* $NetBSD$ */ /*- @@ -419,9 +419,7 @@ iopsp_scsi_cmd(xs) tid = IOPSP_TIDMAP(sc->sc_tidmap, link->target, link->lun); if (tid == IOPSP_TID_ABSENT || tid == IOPSP_TID_INUSE) { xs->error = XS_SELTIMEOUT; - s = splbio(); scsi_done(xs); - splx(s); return; } @@ -439,9 +437,7 @@ iopsp_scsi_cmd(xs) } else xs->error = XS_NOERROR; - s = splbio(); scsi_done(xs); - splx(s); return; } @@ -486,9 +482,7 @@ iopsp_scsi_cmd(xs) if (error) { xs->error = XS_DRIVER_STUFFUP; iop_msg_free(iop, im); - s = splbio(); scsi_done(xs); - splx(s); return; } if ((xs->flags & SCSI_DATA_IN) == 0) @@ -509,9 +503,7 @@ iopsp_scsi_cmd(xs) iop_msg_unmap(iop, im); iop_msg_free(iop, im); xs->error = XS_DRIVER_STUFFUP; - s = splbio(); scsi_done(xs); - splx(s); } } |