diff options
| author | Marc Espie <espie@cvs.openbsd.org> | 1999-11-20 18:52:01 +0000 |
|---|---|---|
| committer | Marc Espie <espie@cvs.openbsd.org> | 1999-11-20 18:52:01 +0000 |
| commit | 5514cce54eeb6b5b2fc4bc8ec005b474e563c9e2 (patch) | |
| tree | 5116bee8052fbccf26146a95d6ddcdae6ba752ff /sys/dev/pci/brooktree848.c | |
| parent | 1c4a3676fce5aeb3e26ee82bb20b040dbda864d6 (diff) | |
ioctl arguments are u_long.
Replaces `undefined' code with `defined' behavior...
gcc 2.96 performs switch cases range analysis, warns about unreachable
cases, and weeds them out.
In
switch(i) {
case VALUE:
}
VALUE is first coerced into the type of i. If i is signed, VALUE is
unsigned and exceeds i range, you lose... the result of the conversion
is undefined.
Diffstat (limited to 'sys/dev/pci/brooktree848.c')
| -rw-r--r-- | sys/dev/pci/brooktree848.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/sys/dev/pci/brooktree848.c b/sys/dev/pci/brooktree848.c index 3fd0f7c7a12..b0af9eee599 100644 --- a/sys/dev/pci/brooktree848.c +++ b/sys/dev/pci/brooktree848.c @@ -1,4 +1,4 @@ -/* $OpenBSD: brooktree848.c,v 1.13 1999/11/03 19:22:52 angelos Exp $ */ +/* $OpenBSD: brooktree848.c,v 1.14 1999/11/20 18:51:59 espie Exp $ */ /* $Roger: brooktree848.c,v 1.85 1999/06/12 14:54:54 roger Exp $ */ /* BT848 Driver for Brooktree's Bt848, Bt848A, Bt849A, Bt878, Bt879 based cards. @@ -1351,7 +1351,7 @@ static int video_open( bktr_ptr_t bktr ); static int video_close( bktr_ptr_t bktr ); static int video_read( bktr_ptr_t bktr, int unit, dev_t dev, struct uio *uio ); static int video_ioctl( bktr_ptr_t bktr, int unit, - int cmd, caddr_t arg, struct proc* pr ); + u_long cmd, caddr_t arg, struct proc* pr ); static void start_capture( bktr_ptr_t bktr, unsigned type ); static void set_fps( bktr_ptr_t bktr, u_short fps ); @@ -1363,7 +1363,7 @@ static void set_fps( bktr_ptr_t bktr, u_short fps ); static int tuner_open( bktr_ptr_t bktr ); static int tuner_close( bktr_ptr_t bktr ); static int tuner_ioctl( bktr_ptr_t bktr, int unit, - int cmd, caddr_t arg, struct proc* pr ); + u_long cmd, caddr_t arg, struct proc* pr ); static int tuner_getchnlset( struct bktr_chnlset *chnlset ); static int tv_channel( bktr_ptr_t bktr, int channel ); @@ -1406,7 +1406,7 @@ static void remote_read(bktr_ptr_t bktr, struct bktr_remote *remote); * ioctls common to both video & tuner. */ static int common_ioctl( bktr_ptr_t bktr, bt848_ptr_t bt848, - int cmd, caddr_t arg ); + u_long cmd, caddr_t arg ); /* @@ -2178,7 +2178,7 @@ vbi_read(bktr_ptr_t bktr, dev_t dev, struct uio *uio) * video ioctls */ static int -video_ioctl( bktr_ptr_t bktr, int unit, int cmd, caddr_t arg, struct proc* pr ) +video_ioctl( bktr_ptr_t bktr, int unit, u_long cmd, caddr_t arg, struct proc* pr ) { bt848_ptr_t bt848; volatile u_char c_temp; @@ -2782,7 +2782,7 @@ video_ioctl( bktr_ptr_t bktr, int unit, int cmd, caddr_t arg, struct proc* pr ) * tuner ioctls */ static int -tuner_ioctl( bktr_ptr_t bktr, int unit, int cmd, caddr_t arg, struct proc* pr ) +tuner_ioctl( bktr_ptr_t bktr, int unit, u_long cmd, caddr_t arg, struct proc* pr ) { bt848_ptr_t bt848; int tmp_int; @@ -3176,7 +3176,7 @@ tuner_ioctl( bktr_ptr_t bktr, int unit, int cmd, caddr_t arg, struct proc* pr ) * common ioctls */ int -common_ioctl( bktr_ptr_t bktr, bt848_ptr_t bt848, int cmd, caddr_t arg ) +common_ioctl( bktr_ptr_t bktr, bt848_ptr_t bt848, u_long cmd, caddr_t arg ) { int pixfmt; unsigned int temp; |