diff options
| author | Miod Vallat <miod@cvs.openbsd.org> | 2006-06-23 06:27:13 +0000 |
|---|---|---|
| committer | Miod Vallat <miod@cvs.openbsd.org> | 2006-06-23 06:27:13 +0000 |
| commit | 8fe25da9d7762dba747313181158c50980ec44e0 (patch) | |
| tree | 1549a3c414202ab70b3d2420c536b509f0fa2c81 /sys/dev/usb/umodem.c | |
| parent | 3d772db769af639e71686fe04b7b9bafc9aa27de (diff) | |
In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@
Diffstat (limited to 'sys/dev/usb/umodem.c')
| -rw-r--r-- | sys/dev/usb/umodem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/usb/umodem.c b/sys/dev/usb/umodem.c index c3f965cee40..38421362b55 100644 --- a/sys/dev/usb/umodem.c +++ b/sys/dev/usb/umodem.c @@ -1,4 +1,4 @@ -/* $OpenBSD: umodem.c,v 1.20 2005/11/21 18:16:44 millert Exp $ */ +/* $OpenBSD: umodem.c,v 1.21 2006/06/23 06:27:12 miod Exp $ */ /* $NetBSD: umodem.c,v 1.45 2002/09/23 05:51:23 simonb Exp $ */ /* @@ -718,7 +718,7 @@ umodem_activate(device_ptr_t self, enum devact act) switch (act) { case DVACT_ACTIVATE: - return (EOPNOTSUPP); + break; case DVACT_DEACTIVATE: sc->sc_dying = 1; |