diff options
| author | Brad Smith <brad@cvs.openbsd.org> | 2005-08-01 05:36:50 +0000 |
|---|---|---|
| committer | Brad Smith <brad@cvs.openbsd.org> | 2005-08-01 05:36:50 +0000 |
| commit | 2e4c19f779ce48faaf5abcaa186def74956a6981 (patch) | |
| tree | 2a7d441b21de326c5a27b994bce0b47dcb3dd0e7 /sys/dev/usb/uyap.c | |
| parent | 0fd85d9caed3489931a1fa9c2b7520960293653d (diff) | |
Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.
From augustss NetBSD
ok dlg@ pascoe@
Diffstat (limited to 'sys/dev/usb/uyap.c')
| -rw-r--r-- | sys/dev/usb/uyap.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/sys/dev/usb/uyap.c b/sys/dev/usb/uyap.c index a03903edf25..d93760c8749 100644 --- a/sys/dev/usb/uyap.c +++ b/sys/dev/usb/uyap.c @@ -1,4 +1,4 @@ -/* $OpenBSD: uyap.c,v 1.8 2004/12/19 15:20:13 deraadt Exp $ */ +/* $OpenBSD: uyap.c,v 1.9 2005/08/01 05:36:49 brad Exp $ */ /* $NetBSD: uyap.c,v 1.6 2002/07/11 21:14:37 augustss Exp $ */ /* @@ -95,11 +95,13 @@ USB_ATTACH(uyap) { USB_ATTACH_START(uyap, sc, uaa); usbd_device_handle dev = uaa->device; - char devinfo[1024]; + char *devinfop; - usbd_devinfo(dev, 0, devinfo, sizeof devinfo); + devinfop = usbd_devinfo_alloc(dev, 0); USB_ATTACH_SETUP; - printf("%s: %s\n", USBDEVNAME(sc->sc_dev), devinfo); + printf("%s: %s\n", USBDEVNAME(sc->sc_dev), devinfop); + usbd_devinfo_free(devinfop); + printf("%s: downloading firmware\n", USBDEVNAME(sc->sc_dev)); sc->sc_udev = dev; |