diff options
| author | Niklas Hallqvist <niklas@cvs.openbsd.org> | 2001-06-26 07:47:30 +0000 |
|---|---|---|
| committer | Niklas Hallqvist <niklas@cvs.openbsd.org> | 2001-06-26 07:47:30 +0000 |
| commit | 4cbe9a5016007cdefccbae891cea2966fa8e3dcc (patch) | |
| tree | 212ca688e20b5372855915e8c6ab80560f5e1042 /sys/dev | |
| parent | 8125b87363f1ab8bcbad3460f27b0cf336ac85f6 (diff) | |
Comment about the bus_space_alloc calls and their problems
Diffstat (limited to 'sys/dev')
| -rw-r--r-- | sys/dev/i2o/iop.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/sys/dev/i2o/iop.c b/sys/dev/i2o/iop.c index 5fd67e54dbe..e64b53f7325 100644 --- a/sys/dev/i2o/iop.c +++ b/sys/dev/i2o/iop.c @@ -1,4 +1,4 @@ -/* $OpenBSD: iop.c,v 1.4 2001/06/26 07:35:04 mickey Exp $ */ +/* $OpenBSD: iop.c,v 1.5 2001/06/26 07:47:29 niklas Exp $ */ /* $NetBSD: iop.c,v 1.12 2001/03/21 14:27:05 ad Exp $ */ /*- @@ -1264,6 +1264,10 @@ iop_systab_set(struct iop_softc *sc) ioa[1] = sc->sc_status.desiredpriviosize; if (mema[1] != 0) { + /* + * XXX This will waste virtual memory. We need a flag to tell + * bus_space_alloc to just reserve, not actually map the area. + */ rv = bus_space_alloc(sc->sc_bus_memt, 0, 0xffffffff, letoh32(mema[1]), PAGE_SIZE, 0, 0, &boo, &bsh); mema[0] = htole32(boo); @@ -1276,6 +1280,11 @@ iop_systab_set(struct iop_softc *sc) } if (ioa[1] != 0) { + /* + * XXX This will potentially waste virtual memory. We + * need a flag to tell bus_space_alloc to just + * reserve, not actually map the area. + */ rv = bus_space_alloc(sc->sc_bus_iot, 0, 0xffff, letoh32(ioa[1]), 0, 0, 0, &boo, &bsh); ioa[0] = htole32(boo); |